Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce number of mypy warnings #1023

Merged
merged 31 commits into from
Nov 15, 2024
+17 −16
Merged

chore: reduce number of mypy warnings #1023

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
1081d90
Fix mypy warning "Incompatible default for argument "openapi_file_pat…
dave42w Nov 11, 2024
4e8dc43
fix event_handler type
dave42w Nov 11, 2024
f97e49d
Fix subrouter http methods to match Robyn with auth_required
dave42w Nov 11, 2024
e78c6f9
work around for mutiprocess typing from https://github.com/uqfoundati…
dave42w Nov 11, 2024
75cefeb
added comment on why double import multiprocess(ing)
dave42w Nov 11, 2024
b04fec7
failing tests for subrouter authentication: AuthenticationNotConfigur…
dave42w Nov 11, 2024
fb192cd
failing tests for subrouter authentication: AuthenticationNotConfigur…
dave42w Nov 11, 2024
0253584
failing tests for subrouter authentication: AuthenticationNotConfigur…
dave42w Nov 11, 2024
8d5f654
use headers.contain instead of in headers
dave42w Nov 11, 2024
22f3d50
mypy detected os.cpu_count can return none in which case we tried to …
dave42w Nov 11, 2024
cbcbd63
add return type None to def __init__ so get type checking inside the …
dave42w Nov 11, 2024
13282d4
Add list type to self.built_rust_binaries
dave42w Nov 11, 2024
f982164
Fixed some mypy issues in openapi.py but more remain
dave42w Nov 11, 2024
38d7c60
Fixed some mypy issues but some remain (Line 196&197)
dave42w Nov 11, 2024
0ee88ef
Merge branch 'sparckles:main' into my-py
dave42w Nov 12, 2024
4a222bd
correct get_openapi_docs_page to return a FileResponse
dave42w Nov 12, 2024
d535adf
merge
dave42w Nov 12, 2024
df289ec
ignore type for multiprocess and nestd
dave42w Nov 12, 2024
562a05d
ignore type for multiprocess
dave42w Nov 12, 2024
719c344
Use typing.Tuple for Python 3.8 compatibility
dave42w Nov 13, 2024
947d4db
Fix return type to match Response from html instead of FileResponse
dave42w Nov 14, 2024
e350e5c
Update robyn/openapi.py
sansyrox Nov 14, 2024
4712d1f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 14, 2024
7221ce4
Update robyn/openapi.py
sansyrox Nov 14, 2024
d3de8e7
Update robyn/openapi.py
sansyrox Nov 14, 2024
8ea3de6
Delete integration_tests/test_subrouter_authentication.py
dave42w Nov 14, 2024
fd4cc80
Delete integration_tests/subroutes/__init__.py
dave42w Nov 15, 2024
1885e4a
Delete integration_tests/subroutes/di_subrouter.py
dave42w Nov 15, 2024
aef60aa
Restore subroute integration
dave42w Nov 15, 2024
f8494d0
Remove changes to subroute http methods
dave42w Nov 15, 2024
cc7ee04
Oops used - instead of _
dave42w Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
work around for mutiprocess typing from uqfoundation/multiprocess#128… 
… (comment)
  • Loading branch information
@dave42w
dave42w committed Nov 11, 2024
commit e78c6f9dc7c1cefa56916e115414e0695af8d96f
8 changes: 6 additions & 2 deletions robyn/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@
import os
import socket
from pathlib import Path
from typing import Callable, List, Optional, Tuple, Union
from typing import Callable, List, Optional, Tuple, Union, TYPE_CHECKING

if TYPE_CHECKING:
import multiprocessing as mp
else:
import multiprocess as mp
dave42w marked this conversation as resolved.
Show resolved Hide resolved

import multiprocess as mp
from nestd import get_all_nested

from robyn import status_codes
Expand Down