[WIP] turbovnc: new package #44722
Open
[WIP] turbovnc: new package #44722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
spackbot-app
bot
added
gitlab
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
This was referenced Aug 3, 2024
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
There was a problem hiding this comment.
@teaguesterling There are git conflicts, would continue the review?
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/mesa/package.py
var/spack/repos/builtin/packages/novnc/package.py
var/spack/repos/builtin/packages/turbovnc/package.py
var/spack/repos/builtin/packages/xkeyboard-config/package.py
var/spack/repos/builtin/packages/xorgproto/package.py
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/xorgproto/package.py
All done! ✨ 🍰 ✨
1 file reformatted, 4 files left unchanged.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:145: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]" [arg-type]
lib/spack/spack/version/version_types.py:452: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]" [arg-type]
lib/spack/spack/version/version_types.py:481: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]" [arg-type]
lib/spack/spack/variant.py:131: error: Unsupported right operand type for in ("Union[Collection[Any], Callable[..., Any]]") [operator]
Found 4 errors in 2 files (checked 621 source files)
mypy found errors
I've updated the branch with style fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the turbovnc package to get a desktop environment up and running from Spack. It was used to test the Xfce4 stack in #44646.
Update: Given the questions around mesa and the issues with new providers, I'm going to break out three additional PRs as dependencies to this. Once the following PRs are merged in, this should be ready to go.
While it worked pretty well, there were a few additional changes needed:
dri.sothat isn't getting provided by Spack, so this will probably break outside of the Ubuntu image. Update: adding the commented out egl variant to mesa provided this.vncserverdirectly with an xstartup path and/or novnc works. It was important for this to activate the spack environment of choice and use dbus-launch.