Skip to content

Setting input and output frames to the same type without explicit names causes conflict #327

Open
@Cadair

Description

Take for example this:

w = WCS(forward_transform=m.Tabular1D(points=np.arange(10)*u.pix,
                                      lookup_table=np.arange(10)*u.km),
        output_frame=frame,
        input_frame=cf.CoordinateFrame(1, "PIXEL", (0,), unit=(u.pix,))
        )
w.world_to_pixel(0*u.km)

The w.input_frame property returns the output frame because they have the same name (defaults to the name of the class).

Activity

added a commit that references this issue on Nov 11, 2020
Cadair

Cadair commented on May 31, 2022

@Cadair
CollaboratorAuthor

What would a good fix to this be? I keep running into it and it's really confusing till I remember.

added this to the 1.0 milestone on Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Setting input and output frames to the same type without explicit names causes conflict · Issue #327 · spacetelescope/gwcs