Arrivals blacklist for bluespace lockers and QSIs #34072
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Untriaged
crazybrain23
changed the title
crazybrain23
added
P3: Standard
| @@ -45,6 +46,8 @@ protected override void Started(EntityUid uid, BluespaceLockerRuleComponent comp | |||
| _bluespaceLocker.GetTarget(potentialLink, comp, true); | |||
| _bluespaceLocker.BluespaceEffect(potentialLink, comp, comp, true); | |||
|
|
|||
| EnsureComp<ArrivalsBlacklistComponent>(potentialLink); // To stop people getting to arrivals terminal | |||
There was a problem hiding this comment.
Wouldn't this only blacklist one of the two lockers since the other one is assigned in GetTarget?
This should probably be moved to the OnStartup function for the BluespaceLockerComponent so that all bluespace lockers are arrival shuttle immune.
|
Also storing the QSI inside a storage container will make it teleport to the center of the shuttle instead of staying at the position of the container. But that can be fixed in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Added the arrivals blacklist to bluespace lockers and quantum spin inverters.
Why / Balance
Both bluespace lockers and quantum spin inverters could and have been used to get back to the arrivals terminal. This is a problem because players have recently been building "colonies" out on the arrivals planet map.
This change prevents the method commonly used to get to the terminal (bluespace lockers) and another method I knew of (quantum spin inverters).
Technical details
In the bluespace locker event, just after the lockers are configured, I made it ensure the locker has the arrivals blacklist component. As for the quantum spin inverter, I just added the component in the yaml.
Media
(QSI worked in exactly the same way so screenshots are pointless)
Requirements
## Breaking changesChangelog
🆑 crazybrain