The Bartender can now make Eggnog #34065
Open
+85
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Untriaged
|
RSI Diff Bot; head commit 4290cc3 merging into 7803254 Resources/Textures/Objects/Consumable/Drinks/eggnogglass.rsi
|
2 tasks
slarticodefast
requested changes
Dec 25, 2024
|
i suggest to add the recipe to the cl |
|
I don't know what caused that test to fail now. It doesn't like non fizzy eggnog. |
|
heisentest fail, someone has to rerun tests |
|
Yep, that's #32248 again. Rerunning tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
The Bartender can now make Eggnog. It comes in a wonderful egg shaped glass.
Why / Balance
I wanted to add eggnog.
Technical details
Added eggnog recipe (drinks.yml, alcohol.yml, and other drinks.yml), eggnog sprite (eggnogglass.rsi), and eggnog descriptors (flavors.yml, flavor-profiles.ftl, and alcohol.ftl). Eggnog recipe is 1u egg, 4u milk, 5u rum, all shaken. This produces 10u of eggnog. Eggnog glass sprite has four fill stages. NOTE: Copyright info may be missing from meta.json, wasn't sure if it was needed for this.
Media
Requirements
Breaking changes
Changelog
🆑