Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better PowerCharge menu wrapping (retry) #34036

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Better PowerCharge menu wrapping (retry) #34036

wants to merge 2 commits into from

Conversation

c4llv07e
Copy link
Contributor

@c4llv07e c4llv07e commented Dec 23, 2024 •
edited
Loading

About the PR

See #33656

Fixed and slightly edited the PowerCharge menu. Now on the RU localization, no text will climb where it is not needed.

They've granted permissions (Russian channel):
https://discord.com/channels/310555209753690112/1278342990305300491/1320747429712363521

So I'll finish this.

Why / Balance

Looks better

Media

Before:
image

After:
image

Requirements

Breaking changes

Changelog
🆑 VlaDOS1408

  • fix: Fixed Gravity gen menu resizing! Now it looks like it should.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: UI Changes: Might require knowledge of UI design or code. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. and removed size/S Denotes a PR that changes 10-99 lines. labels Dec 23, 2024
@PJB3005
Copy link
Member

PJB3005 commented Dec 23, 2024

Why is the wattage under "charge" instead of power? That doesn't make sense.

@c4llv07e
Copy link
Contributor Author

Why is the wattage under "charge" instead of power? That doesn't make sense.

Should I then add a "Consumption" field?

@PJB3005
Copy link
Member

PJB3005 commented Dec 23, 2024

Why is the wattage under "charge" instead of power? That doesn't make sense.

Should I then add a "Consumption" field?

Why can't it be left as-is?

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines. label Dec 24, 2024
@c4llv07e
Copy link
Contributor Author

Why can't it be left as-is?

Personally, I find it confusing. Is it consumption? Or is it capacity? You can't tell for sure on the first look.

Anyway, I corrected it.

image

@PJB3005
Copy link
Member

PJB3005 commented Dec 24, 2024

Is it consumption? Or is it capacity?

Watts is a unit of power, not energy. It cannot be capacity by definition.

@ScarKy0 ScarKy0 added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: UI Changes: Might require knowledge of UI design or code. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c4llv07e @PJB3005 @ScarKy0 @VlaDOS1408