Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to paint multiple airlocks #34001

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Allow to paint multiple airlocks #34001

merged 2 commits into from
Dec 24, 2024

Conversation

lzk228
Copy link
Contributor

@lzk228 lzk228 commented Dec 22, 2024 •
edited
Loading

About the PR

title + fixes #34000
plus you can now cancel doafter by pressing on the door you are painting

Why / Balance

why are we allowed to paint multiple pipes but not airlocks?

Technical details

not much, just removed check for doafter and the doafter saving

Media

2024-12-22_03-31-10.mp4

Requirements

Breaking changes

Removed AirlockDoAfter datafield from SprayPainterComponent

Changelog

🆑

  • tweak: Now you are allowed to paint multiple airlocks with the spray painter. Along with that you can cancel the doafter by clicking on the door you are painting.
    ADMIN:
  • fix: Fixed spray painter using while being aghost.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 22, 2024
@beck-thompson beck-thompson added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. A: Engineering Area: Engineering department, including Atmospherics. T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 22, 2024
@PJB3005 PJB3005 merged commit 1cbc8c1 into space-wizards:master Dec 24, 2024
14 checks passed
@lzk228 lzk228 deleted the 12-22-spray-painter branch December 24, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalgearsloth metalgearsloth metalgearsloth approved these changes

@PJB3005 PJB3005 PJB3005 approved these changes

Assignees
No one assigned
Labels
A: Engineering Area: Engineering department, including Atmospherics. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Bugfix Type: Bugs and/or bugfixes T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spray painters only work once
4 participants
@lzk228 @PJB3005 @metalgearsloth @beck-thompson