Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor VSCode QOL Improvements #33891

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Piras314
Copy link
Contributor

@Piras314 Piras314 commented Dec 16, 2024

About the PR

I added Tools & Release run configurations (tested them too):
image

Added Robust YAML (slava0135), Github Pull Requests (GitHub), and the Fluent (macabeus) extension to the recommendations.

And finally, fixed very few comments in fluent files made #like this rather than # like this that would show up as errors with the fluent extension.

Port of Goob-Station/Goob-Station#966 & Goob-Station/Goob-Station#1192 (both of which I am the author of)

Why / Balance

Technical details

Requirements

Breaking changes

Changelog

no cl no fun

…ll requests, gitlens, fluent and yaml extensions to recommendations.
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/L Denotes a PR that changes 1000-4999 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. and removed size/L Denotes a PR that changes 1000-4999 lines. labels Dec 16, 2024
@FairlySadPanda
Copy link
Contributor

FairlySadPanda commented Dec 16, 2024

Not sure why you've smeared out the SynthWave 64 recommendation. Everyone needs their SDE to match their synthwave coding background music.

Poking @PJB3005 on this as this is an interesting idea but she and others here historically have not had a good relationship with Git Kraken:

image

I will say that I've personally had issues with the Red Hat plugin for YAML deciding to hate all declarations of !type, and Gitlens is a... shareware? demoware? plugin that encourages the user to pay for it. Robust LSP is also a community project.

This might be one of those things that's great to merge on loads of downstreams but might not be suitable for upstream.

Github Pull Requests is an extremely firm recommendation though; it makes working with PRs far easier and is the key reason to keep VSCode around for some SS14 work now that Rider is free.

Copy link
Contributor

@Aeshus Aeshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

You'll need to make a separate PR for all of your documentation changes.

On the topic of the PR, I don't think you should include gitlens and should probably use slava0135.robust-yaml instead of ertanic.robust-lsp.

The rest seems good though, thanks again!

.vscode/extensions.json Outdated Show resolved Hide resolved
.vscode/extensions.json Outdated Show resolved Hide resolved
Resources/Locale/en-US/devices/device-network.ftl Outdated Show resolved Hide resolved
@Piras314
Copy link
Contributor Author

I drew over synthwave because I didn't add it to the recommendations for obvious reasons, and that's just a screenshot of my extensions scrolled nicely to a point that shows all the added recommendations.

Red Hat YAML I will remove, I forgot that I hate it.

Gitlens just genuinely makes VSCode's existing integration better. I haven't had to pay for it or anything like that.

.vscode/extensions.json Outdated Show resolved Hide resolved
.vscode/launch.json Show resolved Hide resolved
Resources/Locale/en-US/devices/device-network.ftl Outdated Show resolved Hide resolved
Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com>
@github-actions github-actions bot added the size/L Denotes a PR that changes 1000-4999 lines. label Dec 16, 2024
Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com>
@FairlySadPanda
Copy link
Contributor

FairlySadPanda commented Dec 16, 2024

I'll agree Gitlens is an improvement but I just hesitate as it absolutely nags the user about its paid features. Above my contributor paygrade (of minus eleventy billion dollars) to decide on.

The config runners for things like release builds looks handy fwiw but it's a bit esoteric for most developers; this is probably one for a maint who works on the build process to read.

@Aeshus Aeshus added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 16, 2024
@Piras314
Copy link
Contributor Author

I removed gitlens and changed from robust LSP to robust YAML

@FairlySadPanda
Copy link
Contributor

FairlySadPanda commented Dec 16, 2024

For the best. Now if only someone could PR making the VS Code C# language engine faster for Robust work... it's embarrasingly slow compared to Rider.

@Piras314
Copy link
Contributor Author

For the best. Now if only someone could PR making the VS Code C# language engine faster for Robust work

wyci :godmode:

@Piras314
Copy link
Contributor Author

The main reason for the config runners is just so devs can quickly for example run a tools config for mapping, or go onto release if they're dealing with some weird bugs that only happen on debug or release (which has happened...) or if they just want to test some stuff out in regular old release sandbox.

@Piras314 Piras314 requested a review from Aeshus December 16, 2024 18:08
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Dec 16, 2024
Copy link
Contributor

@Aeshus Aeshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

You still need to remove the Fluent formatting changes from this PR. Other than that, this seems good.

(I don't personally use VSCode so I can't really verify functionality or best practices.)

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed size/L Denotes a PR that changes 1000-4999 lines. labels Dec 22, 2024
@Piras314 Piras314 requested a review from Aeshus December 22, 2024 20:01
Copy link
Contributor

@Aeshus Aeshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though we’ll need a VSC user to sign off and verify it works.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants