-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor VSCode QOL Improvements #33891
base: master
Are you sure you want to change the base?
Conversation
…ll requests, gitlens, fluent and yaml extensions to recommendations.
Not sure why you've smeared out the SynthWave 64 recommendation. Everyone needs their SDE to match their synthwave coding background music. Poking @PJB3005 on this as this is an interesting idea but she and others here historically have not had a good relationship with Git Kraken: I will say that I've personally had issues with the Red Hat plugin for YAML deciding to hate all declarations of !type, and Gitlens is a... shareware? demoware? plugin that encourages the user to pay for it. Robust LSP is also a community project. This might be one of those things that's great to merge on loads of downstreams but might not be suitable for upstream. Github Pull Requests is an extremely firm recommendation though; it makes working with PRs far easier and is the key reason to keep VSCode around for some SS14 work now that Rider is free. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
You'll need to make a separate PR for all of your documentation changes.
On the topic of the PR, I don't think you should include gitlens and should probably use slava0135.robust-yaml
instead of ertanic.robust-lsp
.
The rest seems good though, thanks again!
I drew over synthwave because I didn't add it to the recommendations for obvious reasons, and that's just a screenshot of my extensions scrolled nicely to a point that shows all the added recommendations. Red Hat YAML I will remove, I forgot that I hate it. Gitlens just genuinely makes VSCode's existing integration better. I haven't had to pay for it or anything like that. |
Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com>
Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com>
I'll agree Gitlens is an improvement but I just hesitate as it absolutely nags the user about its paid features. Above my contributor paygrade (of minus eleventy billion dollars) to decide on. The config runners for things like release builds looks handy fwiw but it's a bit esoteric for most developers; this is probably one for a maint who works on the build process to read. |
I removed gitlens and changed from robust LSP to robust YAML |
For the best. Now if only someone could PR making the VS Code C# language engine faster for Robust work... it's embarrasingly slow compared to Rider. |
wyci |
The main reason for the config runners is just so devs can quickly for example run a tools config for mapping, or go onto release if they're dealing with some weird bugs that only happen on debug or release (which has happened...) or if they just want to test some stuff out in regular old release sandbox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
You still need to remove the Fluent formatting changes from this PR. Other than that, this seems good.
(I don't personally use VSCode so I can't really verify functionality or best practices.)
This reverts commit 4037e8f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, though we’ll need a VSC user to sign off and verify it works.
Thanks!
About the PR
I added Tools & Release run configurations (tested them too):
Added Robust YAML (slava0135), Github Pull Requests (GitHub), and the Fluent (macabeus) extension to the recommendations.
And finally, fixed very few comments in fluent files made
#like this
rather than# like this
that would show up as errors with the fluent extension.Port of Goob-Station/Goob-Station#966 & Goob-Station/Goob-Station#1192 (both of which I am the author of)
Why / Balance
Technical details
Requirements
Breaking changes
Changelog
no cl no fun