-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update static logger to sawmill #33705
base: master
Are you sure you want to change the base?
Conversation
I am not an expert on the whole infrastructure stuff and not sure how all of this
so that we wouldn't need to create a new logger on every object instantiation? I guess maintainers may want to comment if it makes sense to make all of them |
Ah, I checked the implementation of In the end I guess none of this may matter at this point as I saw other places where |
Content.Server/Preferences/Managers/ServerPreferencesManager.cs
Outdated
Show resolved
Hide resolved
forgot to post this:
There was a lot of trouble with null deref segfaults (and may still be) |
for #33279