Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors The GhostUI Warp Menu #33694

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Conversation

vero5123
Copy link
Contributor

@vero5123 vero5123 commented Dec 3, 2024

About the PR

Refactored the ghost ui warp menu to be more user-friendly and intuitive.

TODO:

  • Utilize the job icons in the warp menu.
  • Refactor the buttons to avoid the color saturation issue seen with brighter department colors.

Why / Balance

I think it's a decent QOL change for observers.

Technical details

We now utilize the department name and its associated color to categorize and then color the warp buttons. Any warp without an attached mob and an associated department will fall under the other category.

Media

Edit: Latest changes

UI5.mp4

One can now warp to a ghost mob

UI6.mp4

Ghost roles have their category if they don't fall under a department

UI7.mp4

Requirements

Breaking changes

The GhostWarp struct now takes two additional optional arguments in the constructor, categoryName and warpColor. In addition, the GhostComponent now has an extra field HideGhostWarp which can optionally hide the visibility of certain ghost types, such as admin ghosts.

Changelog
🆑

  • tweak: Refactored the ghost ui menu to instead utilize departments when categorizing and sorting warp locations.

@github-actions github-actions bot added size/L Denotes a PR that changes 1000-4999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: UI Changes: Might require knowledge of UI design or code. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/L Denotes a PR that changes 1000-4999 lines. labels Dec 3, 2024
@vero5123 vero5123 changed the title warp menu refactor Tweaks the GhostUI warp menu Dec 3, 2024
@vero5123 vero5123 changed the title Tweaks the GhostUI warp menu Refactors The GhostUI Warp Menu Dec 3, 2024
@ArtisticRoomba
Copy link
Contributor

The blue on blue text might be difficult to read for some people. Maybe keep the color of the name white and have the background the only thing colored instead?

@vero5123
Copy link
Contributor Author

vero5123 commented Dec 3, 2024

The blue on blue text might be difficult to read for some people. Maybe keep the color of the name white and have the background the only thing colored instead?

Screen Shot 2024-12-03 at 12 22 36 AM

@UbaserB
Copy link
Member

UbaserB commented Dec 3, 2024

You could probably color the text to be at 50% opacity of the color used as the background, as an overlay on top of white. This way it'd be consistent across all jobs and look pretty good i think. The % can be tweaked as needed for contrast and clarity.

@ArtisticRoomba
Copy link
Contributor

ArtisticRoomba commented Dec 3, 2024

Also a minor suggestion, maybe the buttons to the mapped beacons could inherit the beacon color? Although it might be too much varied color, might be best to have this just for roles.

@vero5123
Copy link
Contributor Author

vero5123 commented Dec 3, 2024

You could probably color the text to be at 50% opacity of the color used as the background, as an overlay on top of white. This way it'd be consistent across all jobs and look pretty good i think. The % can be tweaked as needed for contrast and clarity.

UI5.mp4

text now is blended with the base color and white when hovering over it, ok I'm going to bed now lol.

@NoElkaTheGod
Copy link
Contributor

Not as good as GP's ghost warp, but a step in the right direction nonetheless.

@vero5123
Copy link
Contributor Author

vero5123 commented Dec 3, 2024

Not as good as GP's ghost warp, but a step in the right direction nonetheless.

who or what is gp?

@vero5123
Copy link
Contributor Author

vero5123 commented Dec 3, 2024

Also a minor suggestion, maybe the buttons to the mapped beacons could inherit the beacon color? Although it might be too much varied color, might be best to have this just for roles.

It should probably just be for roles, either way, I'll add the functionality for assigning non-mob warp points colors as well.

@github-actions github-actions bot added the size/L Denotes a PR that changes 1000-4999 lines. label Dec 3, 2024
@vero5123
Copy link
Contributor Author

vero5123 commented Dec 3, 2024

Ghost mobs are now warpable.

UI6.mp4

@UbaserB
Copy link
Member

UbaserB commented Dec 4, 2024

does the ghost warp include admins? Admins probably shouldn't be warpable to

@vero5123 vero5123 requested a review from DrSmugleaf as a code owner December 4, 2024 01:15
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Dec 4, 2024
@vero5123
Copy link
Contributor Author

vero5123 commented Dec 4, 2024

does the ghost warp include admins? Admins probably shouldn't be warpable to

admin ghosts are hidden.

@vero5123
Copy link
Contributor Author

vero5123 commented Dec 4, 2024

I'm happy with it, ready for review.

How to test this pr:

  1. Launch the server and 2 clients.
  2. /ghost or /aghost from either of the clients and the other mob will be seen in the ghost menu. You can ghost both clients just know that Aghosts won't be visible in the ghost warp menu, normal ghosts will.
  3. profit.

@vero5123
Copy link
Contributor Author

vero5123 commented Dec 4, 2024

ghost roles will now be displayed separately if the role doesn't fall under a department. (previously, revenants were simply hidden from the warp menu)

UI7.mp4

@NoElkaTheGod
Copy link
Contributor

Not as good as GP's ghost warp, but a step in the right direction nonetheless.

who or what is gp?

Giedi Prime, formerly known as White Dream, a pretty technicaly advanced russian server. They don't seem to know what "game design" means though, but some of their additions are pretty impressive.

@vero5123
Copy link
Contributor Author

vero5123 commented Dec 6, 2024

Not as good as GP's ghost warp, but a step in the right direction nonetheless.

who or what is gp?

Giedi Prime, formerly known as White Dream, a pretty technicaly advanced russian server. They don't seem to know what "game design" means though, but some of their additions are pretty impressive.

I would go and look to see what you're talking about, but currently 0 people are online and I don't understand Russian. I guess I'll just clone and test locally...

Edit: Their repo isn't open to the public. Time to bribe some Russians to get a few images for me to see.

Edit 2: Ruski Boy gave me a jpeg, yeah, their ui is goated.
rus

rus2

However, not AGPL, meaning, the waters get muddy for what I can and can't replicate.
They also need to set cliptext = true from the looks of it.

@vero5123 vero5123 marked this pull request as draft December 11, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: UI Changes: Might require knowledge of UI design or code. S: Needs Review Status: Requires additional reviews before being fully accepted size/L Denotes a PR that changes 1000-4999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants