-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors The GhostUI Warp Menu #33694
base: master
Are you sure you want to change the base?
Conversation
The blue on blue text might be difficult to read for some people. Maybe keep the color of the name white and have the background the only thing colored instead? |
You could probably color the text to be at 50% opacity of the color used as the background, as an overlay on top of white. This way it'd be consistent across all jobs and look pretty good i think. The % can be tweaked as needed for contrast and clarity. |
Also a minor suggestion, maybe the buttons to the mapped beacons could inherit the beacon color? Although it might be too much varied color, might be best to have this just for roles. |
UI5.mp4text now is blended with the base color and white when hovering over it, ok I'm going to bed now lol. |
Not as good as GP's ghost warp, but a step in the right direction nonetheless. |
who or what is gp? |
It should probably just be for roles, either way, I'll add the functionality for assigning non-mob warp points colors as well. |
Ghost mobs are now warpable. UI6.mp4 |
does the ghost warp include admins? Admins probably shouldn't be warpable to |
admin ghosts are hidden. |
I'm happy with it, ready for review. How to test this pr:
|
ghost roles will now be displayed separately if the role doesn't fall under a department. (previously, revenants were simply hidden from the warp menu) UI7.mp4 |
Giedi Prime, formerly known as White Dream, a pretty technicaly advanced russian server. They don't seem to know what "game design" means though, but some of their additions are pretty impressive. |
About the PR
Refactored the ghost ui warp menu to be more user-friendly and intuitive.
TODO:
Why / Balance
I think it's a decent QOL change for observers.
Technical details
We now utilize the department name and its associated color to categorize and then color the warp buttons. Any warp without an attached mob and an associated department will fall under the other category.
Media
Edit: Latest changes
UI5.mp4
One can now warp to a ghost mob
UI6.mp4
Ghost roles have their category if they don't fall under a department
UI7.mp4
Requirements
Breaking changes
The GhostWarp struct now takes two additional optional arguments in the constructor,
categoryName
andwarpColor
. In addition, the GhostComponent now has an extra fieldHideGhostWarp
which can optionally hide the visibility of certain ghost types, such as admin ghosts.Changelog
🆑