Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add security badges #32702

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add security badges #32702

wants to merge 5 commits into from

Conversation

IProduceWidgets
Copy link
Contributor

@IProduceWidgets IProduceWidgets commented Oct 8, 2024 •
edited
Loading

About the PR

They're badges yo.

Why / Balance

Mostly RP? I have an idea to give officers ID numbers, which would go on this and their mk, but later.

Technical details

Media

image
image

Requirements

Breaking changes

Changelog

🆑

  • add: Security officers now have badges!

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

RSI Diff Bot; head commit 5a0f91f merging into dc2899c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/OuterClothing/Vests/detvest.rsi

State Old New Status
equipped-OUTERCLOTHING-vox Modified
equipped-OUTERCLOTHING Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Clothing/Neck/Misc/badges.rsi

State Old New Status
equipped-NECK Added
largebadge Added
sherrifstar Added
sobadge Added

Resources/Textures/Effects/speech.rsi

State Old New Status
security0 Added
security1 Added
security2 Added

Edit: diff updated after 5a0f91f

@shampunj
Copy link
Contributor

shampunj commented Oct 8, 2024

Exclusive to a detective would look good.

@IProduceWidgets
Copy link
Contributor Author

IProduceWidgets commented Oct 8, 2024 •
edited
Loading

I thought about making / upstreaming some sort of "pinning" mechanic so you can pin it to a jumpsuit or to a beret or something. Not sure if that's something we want though.

Feels kind of like we should settle on what to do with cosmetic items since we've also got rings and stuff now.
My feelings are that we might be better off doing an MMO style two-inventory system so we can have lots of little trinkets and whatnot. something like Runescape.

@lzk228
Copy link
Contributor

lzk228 commented Oct 8, 2024

dunno, it looks weird, because as officer ID numbers they just have their ID cards...

@ps3moira
Copy link

ps3moira commented Oct 9, 2024 •
edited
Loading

icon sprites looks way way too big. should be no bigger than a medals sprite

@WhiteGorila
Copy link

these sprites are massive

@Sadie-silly
Copy link
Contributor

please don't make it give sec a different speech bubble.

@ps3moira
Copy link

please don't make it give sec a different speech bubble.

yeah that would make sec abysmal.

@metalgearsloth
Copy link
Contributor

that badge looks YUGE

@superjj18
Copy link
Contributor

please don't make it give sec a different speech bubble.

I'd say tie it to sec gas mask kinda like how in TG the mask makes you sound like a Half Life 2 combine soldier

@Sadie-silly
Copy link
Contributor

please don't make it give sec a different speech bubble.

I'd say tie it to sec gas mask kinda like how in TG the mask makes you sound like a Half Life 2 combine soldier

My main issue with the speech bubble is honestly the way it looks. The red and blue that is used right now just does not look good. If sec were to really have a speech bubble, I believe it should use just the sec colors (red and black) and have some sort of unique design, like the moth and reptilian speech bubbles.

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Security Area: Security department, including Detectives, HoS size/L Denotes a PR that changes 1000-4999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 18, 2024
@Pumkin69
Copy link

Sprites are too big on the ground. No speech bubble. Everything else is cool but make it so they are tied to something like loadout time requirements or the Head of Security handing them out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Security Area: Security department, including Detectives, HoS Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/L Denotes a PR that changes 1000-4999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.