-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI now uses the criminal console instead of the station console to view records. #32307
base: master
Are you sure you want to change the base?
Conversation
why? Criminal records give you less information about the person than station records, and AI shouldn't really be setting criminals to wanted, that's the Wardens job |
Ive never seen the station records be used either way. |
You are correct though about station records havi no more info, I honestly think ai should have both and the ai player can pick and choose what terminals they want on hand with the actions menu Other than that it is perfectly reasonable to give ai quick access without needing to scroll around looking for a terminal to jump into |
As with the mindshield and wanted status vision, I don't really think it's a good idea to push the AI towards security-sided gameplay. Every tool that's given to them is an official designation of "this is what you are expected to do for the station", so having a criminal records computer on demand will make AI players think this is what they should be doing |
You see this is already a thing AI can do by simply flying across the map to security |
Is this really intended? I think AI being able to view criminal records is good, but changing them should be sec's job. |
If Borgs see mind-shield/wanted status then that is a bug |
they do in fact see mindshields and ive never seen it be called a bug |
This was supposed to be changed #26207, not that im against this pr but yes it is intended for Borgs to not see mind-shields or wanted status for the same reasons why AI can't |
I use station records :( |
"AI set x to wanted for y" seems like a perfectly reasonable request for an on-board station ai. AIs job is whatever the crew deems its job to be. Hell if someone asks for the AI to mark someone as wanted the AI literally cannot say no under Asimov laws due to law two. So yes if someone tells the ai to mark someone as wanted it 100% is the ai's job. This QoL change simply makes ai doing that task easier, rather than annoying. |
About the PR
Makes the AI Station Records action instead be the Criminal Records console.
Why / Balance
The station records is useless and just an inferior version of the criminal records console. AI had essentially no use with it anyways. Now you can at least set criminals as wanted when sec asks you to without flying across the map.
Additionally when AI was using the sec console it would constantly get overwriten by whoever else was using it at the time in case several criminals had to be marked and it was annoying, though I guess a rare occurance.
Technical details
Made the CriminalRecordsConsole component networked.
Added a new action for AI to seperate aghost's station records and ai's criminal records. (Since Aghost is supposed to be able to delete the records, which AI couldnt do anyways)
Media
Requirements
Breaking changes
Changelog
🆑