Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI now uses the criminal console instead of the station console to view records. #32307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ScarKy0
Copy link
Contributor

@ScarKy0 ScarKy0 commented Sep 19, 2024

About the PR

Makes the AI Station Records action instead be the Criminal Records console.

Why / Balance

The station records is useless and just an inferior version of the criminal records console. AI had essentially no use with it anyways. Now you can at least set criminals as wanted when sec asks you to without flying across the map.
Additionally when AI was using the sec console it would constantly get overwriten by whoever else was using it at the time in case several criminals had to be marked and it was annoying, though I guess a rare occurance.

Technical details

Made the CriminalRecordsConsole component networked.
Added a new action for AI to seperate aghost's station records and ai's criminal records. (Since Aghost is supposed to be able to delete the records, which AI couldnt do anyways)

Media

image

Requirements

Breaking changes

Changelog

🆑

  • tweak: AI now uses a criminal console instead of the station records console.

@ScarKy0 ScarKy0 marked this pull request as ready for review September 19, 2024 17:03
@ScarKy0 ScarKy0 requested a review from DrSmugleaf as a code owner September 19, 2024 17:03
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Sep 19, 2024
@slarticodefast slarticodefast added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Sep 19, 2024
@Dutch-VanDerLinde
Copy link
Contributor

why? Criminal records give you less information about the person than station records, and AI shouldn't really be setting criminals to wanted, that's the Wardens job

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 19, 2024

why? Criminal records give you less information about the person than station records, and AI shouldn't really be setting criminals to wanted, that's the Wardens job

Ive never seen the station records be used either way.
And security keeps yelling at AI to change wanted status anyways, might as well make it easier whenever possible.

@superjj18
Copy link
Contributor

why? Criminal records give you less information about the person than station records, and AI shouldn't really be setting criminals to wanted, that's the Wardens job

  1. Robocop law set
  2. AI is already perfectly capable of utilizing the criminal records terminals anyways, so this is more QoL than a new functionality/ai powercreep

You are correct though about station records havi no more info, I honestly think ai should have both and the ai player can pick and choose what terminals they want on hand with the actions menu

Other than that it is perfectly reasonable to give ai quick access without needing to scroll around looking for a terminal to jump into

@Plykiya
Copy link
Contributor

Plykiya commented Sep 19, 2024

As with the mindshield and wanted status vision, I don't really think it's a good idea to push the AI towards security-sided gameplay. Every tool that's given to them is an official designation of "this is what you are expected to do for the station", so having a criminal records computer on demand will make AI players think this is what they should be doing

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 19, 2024

As with the mindshield and wanted status vision, I don't really think it's a good idea to push the AI towards security-sided gameplay. Every tool that's given to them is an official designation of "this is what you are expected to do for the station", so having a criminal records computer on demand will make AI players think this is what they should be doing

You see this is already a thing AI can do by simply flying across the map to security
this simply removes the fly across the map part and still serves essentially the same purpose
its not like letting AI see wanted status to report people instantly, simply means u dont gotta cross the map to do what you already could do
Besides borgs can see mindshield status im still confused why AI shouldnt

@0x6273
Copy link
Contributor

0x6273 commented Sep 19, 2024

You see this is already a thing AI can do by simply flying across the map to security
this simply removes the fly across the map part and still serves essentially the same purpose

Is this really intended? I think AI being able to view criminal records is good, but changing them should be sec's job.

@superjj18
Copy link
Contributor

Besides borgs can see mindshield status im still confused why AI shouldnt

If Borgs see mind-shield/wanted status then that is a bug

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 19, 2024

If Borgs see mind-shield/wanted status then that is a bug

they do in fact see mindshields and ive never seen it be called a bug

@superjj18
Copy link
Contributor

If Borgs see mind-shield/wanted status then that is a bug

they do in fact see mindshields and ive never seen it be called a bug

This was supposed to be changed #26207, not that im against this pr but yes it is intended for Borgs to not see mind-shields or wanted status for the same reasons why AI can't

@Moomoobeef
Copy link
Contributor

why? Criminal records give you less information about the person than station records, and AI shouldn't really be setting criminals to wanted, that's the Wardens job

Ive never seen the station records be used either way. And security keeps yelling at AI to change wanted status anyways, might as well make it easier whenever possible.

I use station records :(
And security really just needs to learn that that isn't the AI's job.

@superjj18
Copy link
Contributor

superjj18 commented Sep 23, 2024

And security really just needs to learn that that isn't the AI's job.

"AI set x to wanted for y" seems like a perfectly reasonable request for an on-board station ai. AIs job is whatever the crew deems its job to be. Hell if someone asks for the AI to mark someone as wanted the AI literally cannot say no under Asimov laws due to law two.

So yes if someone tells the ai to mark someone as wanted it 100% is the ai's job. This QoL change simply makes ai doing that task easier, rather than annoying.

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@ScarKy0 ScarKy0 added P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it A: Security Area: Security department, including Detectives, HoS A: Silicons Area: Relates to Silicon roles, including AI. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Security Area: Security department, including Detectives, HoS A: Silicons Area: Relates to Silicon roles, including AI. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants