Fix to puncturase bug cauterizing bleeds in the BloodstreamSystem.cs file, issue #31137 #31656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S: Needs Review
Puncturase-bug-fix.mp4Sorry, just saw that my video didn't upload with the original PR. Hopefully this works. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
S: Merge Conflict
SlamBamActionman
added
the
S: Untriaged
eoineoineoin
added
T: Bugfix
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Are you still working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Changed where bleeding is modifying in BloodstreamSystem.cs. Added logic to gate certain modifications from occurring.
Why / Balance
Previously, the code modified the bleed amount with a total float from the modified damage. This caused a bug with puncturase where a negative amount of damage would heal the bleeding and cause the text for cauterization to appear (issue #31137). Now bleed amount is only changed in 2 scenarios in this script: Heat damage to cause cauterization, or normal damage to cause bleeding. The third case where healing directly heals bleeding works without any logic in the BloodstreamSystem.cs script.
Technical details
Added a function to look through damage dict damage types. Pick out heat damage. If heat damage is present (positive or negative after modifiers) then cauterization occurs. If the total damage is positive, bleed amount is modified as normal.
Media
Requirements
Breaking changes
Changelog