Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galoshes aren't a jani only item #33227

Open
ShakoCross opened this issue Nov 9, 2024 · 2 comments · May be fixed by #33385
Open

Galoshes aren't a jani only item #33227

ShakoCross opened this issue Nov 9, 2024 · 2 comments · May be fixed by #33385
Labels
A: Security Area: Security department, including Detectives, HoS D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Content PR Merged Status: Requires an existing SS14 PR to be merged first. T: New Feature Type: New feature or content, or extending existing content

Comments

@ShakoCross
Copy link

Description

As the title says the galoshes aren't a jani only item, anyone can wear them and i am pretty sure it is a oversight.

Reproduction
-find galoshes
-inspect the galoshes

Screenshots
N/A

Additional context
@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 9, 2024
@ArtisticRoomba
Copy link
Contributor

if you're talking about them being a restricted item, this is a noted issue in #31047

it can be fixed with just YAML at this time but it's kinda shitcodey and it would be best for a much more elegant solution to be done instead

@ShakoCross
Copy link
Author

Yeah i was talking about it not being a restricted item
And is sad to see at it haves shitcode but honestly i would just make them restricted now as galoshes are probably one of the most important items at need to be restricted

@sporkyz sporkyz linked a pull request Nov 18, 2024 that will close this issue
Open
2 tasks
@Boaz1111 Boaz1111 added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. A: Security Area: Security department, including Detectives, HoS S: Needs Content PR Merged Status: Requires an existing SS14 PR to be merged first. T: New Feature Type: New feature or content, or extending existing content and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. T: Bugfix Type: Bugs and/or bugfixes labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: Security Area: Security department, including Detectives, HoS D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Content PR Merged Status: Requires an existing SS14 PR to be merged first. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Job contraband rework sporkyz/space-station-14
3 participants
@ShakoCross @ArtisticRoomba @Boaz1111