Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puncturase heals bleeding #31137

Open
slarticodefast opened this issue Aug 17, 2024 · 0 comments
Open

Puncturase heals bleeding #31137

slarticodefast opened this issue Aug 17, 2024 · 0 comments
Labels
A: Combat Area: Combat features and changes, balancing, feel A: Medical Area: Medical department, including Chemistry D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Content PR Merged Status: Requires an existing SS14 PR to be merged first. T: Bugfix Type: Bugs and/or bugfixes

Comments

@slarticodefast
Copy link
Member

slarticodefast commented Aug 17, 2024 •
edited
Loading

Description

Found on discord by Binbag
https://discord.com/channels/310555209753690112/1274462223787364404

Reproduction

  • hit yourself with a spear a few times
  • inject yourself with puncturase using a hypospray
  • hear a cauterization noise and get a "you feel your wounds painfully close" popup, which should only happen for heat damage

Additional context
Somehow in the OnDamageChanged function in the BloodstreamSystem the healing effect of the Puncturase in combination with the damaging effect of the bloodloss seems to be interpreted the same as positive heat damage, which cauterizes.

More details in the discord thread.

I did not test it but it should probably not use the total here, but just the heat damage
grafik
@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Aug 17, 2024
@slarticodefast slarticodefast added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D3: Low Difficulty: Some codebase knowledge required. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Aug 17, 2024
@TheWalnutKing TheWalnutKing mentioned this issue Aug 30, 2024
Open
@Cojoke-dot Cojoke-dot mentioned this issue Oct 9, 2024
Merged
2 tasks
@ScarKy0 ScarKy0 added T: Bugfix Type: Bugs and/or bugfixes A: Combat Area: Combat features and changes, balancing, feel A: Medical Area: Medical department, including Chemistry S: Needs Content PR Merged Status: Requires an existing SS14 PR to be merged first. labels Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: Combat Area: Combat features and changes, balancing, feel A: Medical Area: Medical department, including Chemistry D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Content PR Merged Status: Requires an existing SS14 PR to be merged first. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ScarKy0 @slarticodefast