Fix early TCP closes due to backend hanging up #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to prevent early closing of TCP connections with no more backend Signed-off-by: Eloi DEMOLIS <eloi.demolis@clever-cloud.com>
Wonshtrum
requested review from
FlorentinDUBOIS,
Keksoj and
llenotre
as code owners
Keksoj
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some TCP connections were closing even though some data was still in flight. This was due to the backend hanging up and
Pipe::check_connectionsonly checking for in-memory buffers, disregarding the kernel ones. We now consider this by checking thereadiness.event.is_readable().