Skip to content

Commit

Permalink
hobo_jquery_ui is now optional, so remove it as a dependency from hob…
Browse files Browse the repository at this point in the history
…o_clean. Our generators now must explicitly add it to Gemfile.
  • Loading branch information
bryanlarsen committed Nov 14, 2012
1 parent ac78c07 commit a39b90f
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def install_default_plugins
say "Installing hobo_jquery plugin..."
install_plugin_helper('hobo_jquery', nil, opts.merge(:skip_gem => true))
say "Installing hobo_jquery_ui plugin..."
install_plugin_helper('hobo_jquery_ui', nil, opts.merge(:skip_gem => true))
install_plugin_helper('hobo_jquery_ui', nil, opts)

say "Installing #{opts[:theme]} theme..."
inject_css_require("jquery-ui/#{opts[:ui_theme]}", opts[:subsite], nil)
Expand Down
2 changes: 1 addition & 1 deletion hobo_clean/hobo_clean.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Gem::Specification.new do |s|
s.description = File.read(File.expand_path('../README', __FILE__))

s.add_runtime_dependency('hobo', ["= #{version}"])
s.add_runtime_dependency('hobo_jquery_ui', ["= #{version}"])
s.add_runtime_dependency('hobo_jquery', ["= #{version}"])

s.files = `git ls-files -x #{name}/* -z`.split("\0")

Expand Down
1 change: 0 additions & 1 deletion hobo_clean/lib/hobo_clean.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
require 'hobo_rapid'
require 'hobo_jquery'
require 'hobo_jquery_ui'

module HoboClean

Expand Down
2 changes: 1 addition & 1 deletion integration_tests/agility_bootstrap/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ gem "hobo", :path => "../.."
# gem "hobo_clean", :path => "../.."
# gem "hobo_clean_sidemenu", :path => "../.."
# gem "hobo_jquery", :path => "../.."
# gem "hobo_jquery_ui", :path => "../.."
gem "hobo_jquery_ui", :path => "../.."

gem "jquery-ui-themes", "~> 0.0.4"

Expand Down
5 changes: 3 additions & 2 deletions integration_tests/agility_bootstrap/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ PATH
specs:
hobo_bootstrap (2.0.0.pre6)
bootstrap-sass (~> 2.1)
hobo (~> 2.0.0.pre1)
hobo_jquery_ui (~> 2.0.0.pre1)
hobo (~> 2.0.0.pre6)
hobo_jquery (~> 2.0.0.pre6)
will_paginate-bootstrap (~> 0.2.1)

PATH
Expand Down Expand Up @@ -262,6 +262,7 @@ DEPENDENCIES
hobo!
hobo_bootstrap!
hobo_bootstrap_ui!
hobo_jquery_ui!
hobo_paperclip!
hobo_simple_color!
hobo_tokeninput!
Expand Down

0 comments on commit a39b90f

Please sign in to comment.