tools: generate update-docker-tags args from sourcegraph/sourcegraph #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobheadxi
force-pushed
the
generate-docker-tags-args
branch
from
d941147 to
48f3b51
Compare
2 tasks
bobheadxi
force-pushed
the
generate-docker-tags-args
branch
from
48f3b51 to
8ea9c6a
Compare
uwedeportivo
approved these changes
Nov 30, 2020
| ) | ||
| args := []string{ | ||
| "run", | ||
| "github.com/slimsag/update-docker-tags", |
There was a problem hiding this comment.
we should probably make this a library and call it directly
There was a problem hiding this comment.
that would be nice in the long run - i think a first step would be a better path towards owning this tool ourselves, however: https://github.com/sourcegraph/sourcegraph/issues/16280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates update-docker-tag args from the master list over in
sourcegraph/sourcegraph(https://github.com/sourcegraph/sourcegraph/pull/16227) instead of requiring manual maintenance. Closes https://github.com/sourcegraph/sourcegraph/issues/15896As a reminder, we can't just wildcard
sourcegraph/*images during version enforcement because we have images that don't conform to our standard versioning (e.g.sourcegraph/alpine)The entrypoint remains the same, so this will not break our tooling/CI that now depends on the script.
Checklist