Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Bucket File download Api #163

Open
hadson19 opened this issue Nov 21, 2019 · 1 comment
Open

Incorrect Bucket File download Api #163

hadson19 opened this issue Nov 21, 2019 · 1 comment

Comments

@hadson19
Copy link

I've looked into the code Firebase Bucket Storage File (firebase-admin: "8.3.0") and found that when we call download - the content should be returned in any case..

  export declare type DownloadResponse = [Buffer];
  export declare type DownloadCallback = (err: RequestError | null, contents: Buffer) => void;

What do you think about this?
Thanks.
@hadson19
Copy link
Author

Should be fixed bu pull request
https://github.com/soumak77/firebase-mock/pull/128/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hadson19