Skip to content

Commit

Permalink
Use api configuration for public dependencies. (KeepSafe#258)
Browse files Browse the repository at this point in the history
Some support annotations and the v7 support Toolbar are both part of the
public api, so they need to be specified as `api` in order for them to
transitively picked up by downstream dependants.
  • Loading branch information
ajalt authored and xiphirx committed Jan 25, 2018
1 parent 7f60a0d commit 2e18dda
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:3.0.1'
classpath 'com.github.dcendents:android-maven-gradle-plugin:1.5'
classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.6'
classpath 'com.github.dcendents:android-maven-gradle-plugin:2.0'
classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.7.3'
}
}

Expand Down
4 changes: 2 additions & 2 deletions taptargetview/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ android {

def supportLibraryVersion = '27.0.2'
dependencies {
implementation "com.android.support:support-annotations:$supportLibraryVersion"
api "com.android.support:support-annotations:$supportLibraryVersion"
api "com.android.support:appcompat-v7:$supportLibraryVersion"
implementation "com.android.support:support-compat:$supportLibraryVersion"
implementation "com.android.support:appcompat-v7:$supportLibraryVersion"
}

install {
Expand Down

0 comments on commit 2e18dda

Please sign in to comment.