Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] #408 - Amplitude 설치 #462

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

[Feat] #408 - Amplitude 설치 #462

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
335e8e0
feat: amplitude - 푸시알림 받았을 때
seungchan2 Dec 12, 2024
7448a34
feat: amplitude - 모두 읽음 버튼 클릭했을 때
seungchan2 Dec 12, 2024
88677dd
feat: amplitude - 숏컷 버튼 클릭했을 때
seungchan2 Dec 12, 2024
2fa9159
feat: amplitude - 알림 상세 조회할 때
seungchan2 Dec 12, 2024
bc07d3a
fix: amplitude - 사용자가 알림 상세 화면을 조회할 때
seungchan2 Dec 12, 2024
27e4382
feat: amplitude - 알림 화면을 조회할 때
seungchan2 Dec 12, 2024
9e817d7
feat: amplitude - 알림 센터 내 알림 숏컷을 탭할 때
seungchan2 Dec 12, 2024
6a551f1
fix: amplitude - 푸시 알림 클릭했을 때
seungchan2 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: amplitude - 사용자가 알림 상세 화면을 조회할 때 
NotificationDetailViewModel에서 푸시 / 알림 들어온 경로 확인이 불가하기 때문에, Coordinator로 amplitude 수정
  • Loading branch information
@seungchan2
seungchan2 committed Dec 12, 2024
commit bc07d3a6d85817c838d4a638db176c2813941860
6 changes: 6 additions & 0 deletions ...S/Projects/Features/NotificationFeature/Sources/Coordinator/NotificationCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ final class NotificationCoordinator: DefaultNotificationCoordinator {
let url = link.url

let destination: NotificationCoordinatorDestination = link.isDeepLink ? .deepLink(url: url) : .webLink(url: url)
AmplitudeInstance.shared.track(eventType: .viewNotificationDetail, eventProperties: [
"notification_id": notificationId,
"open_method": link.isDeepLink ? "푸시알림" : "알림센터",
"contain_deeplink": link.isDeepLink
])

self?.requestCoordinating?(destination)
}

Expand Down
11 changes: 0 additions & 11 deletions ...cationFeature/Sources/NotificationDetailScene/ViewModel/NotificationDetailViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ extension NotificationDetailViewModel {
.withUnretained(self)
.sink { owner, _ in
owner.useCase.getNotificationDetail(notificationId: owner.notificationId)
owner.trackAmplitudeNoticeDetailView(with: owner.notificationId)
}.store(in: cancelBag)

input.shortCutButtonTap
Expand Down Expand Up @@ -122,16 +121,6 @@ extension NotificationDetailViewModel {
return calendar.isDateInToday(date)
}

private func trackAmplitudeNoticeDetailView(with notificationId: String) {
guard let notification else { return }
AmplitudeInstance.shared.track(eventType: .viewNotificationDetail,
eventProperties: [
"notification_id": notificationId,
"open_method": notification.hasDeepLink ? "푸시" : "알림센터",
"contain_deeplink": notification.hasDeepLink
])
}

private func trackAmplitudeShortcutButtonTapped(with notificationId: String) {
AmplitudeInstance.shared.track(eventType: .clickShortcutButton, eventProperties: ["notification_id": notificationId])
}
Expand Down