This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
General cleanup #32980
Merged
General cleanup #32980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
approved these changes
Aug 24, 2023
| @@ -10,7 +10,7 @@ fn main() -> Result<(), std::io::Error> { | |||
| let mut protos = Vec::new(); | |||
| for proto_file in &proto_files { | |||
| let proto = proto_base_path.join(proto_file); | |||
| println!("cargo::rerun-if-changed={}", proto.display()); | |||
| println!("cargo:rerun-if-changed={}", proto.display()); | |||
There was a problem hiding this comment.
Well credit on this one goes to @t-nelson: t-nelson@4e17f71
There was a problem hiding this comment.
oh i guess this'll fix broken docs build in solana-core 🚀
apfitzge
approved these changes
Aug 24, 2023
t-nelson
approved these changes
Aug 24, 2023
| @@ -10,7 +10,7 @@ fn main() -> Result<(), std::io::Error> { | |||
| let mut protos = Vec::new(); | |||
| for proto_file in &proto_files { | |||
| let proto = proto_base_path.join(proto_file); | |||
| println!("cargo::rerun-if-changed={}", proto.display()); | |||
| println!("cargo:rerun-if-changed={}", proto.display()); | |||
Codecov Report
@@ Coverage Diff @@
## master #32980 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 784 784
Lines 212650 212641 -9
=========================================
- Hits 174424 174390 -34
- Misses 38226 38251 +25 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #32961.