Emit FSA error for unions with manually drop fields #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reasons that are not quite clear to me, trying to monomorphize a manually droppable union field causes an internal compile error in rustc. I think for now the best way to deal with this is to throw an error and require the user to manually mark such types as finalizer safe or not depending on their use-case. Ideally we could improve on this at a later date as there is no reason in theory why we shouldn't be able to support union types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons that are not quite clear to me, trying to monomorphize a manually droppable union field causes an internal compile error in rustc. I think for now the best way to deal with this is to throw an error and require the user to manually mark such types as finalizer safe or not depending on their use-case.
Ideally we could improve on this at a later date as there is no reason in theory why we shouldn't be able to support union types.