elk.core.persistence: fixed invalid options being written to elkg ecl…

…ipse-elk#126
soerendomroes · Feb 4, 2017 · e6a591a · e6a591a
1 parent d3ceef2
commit e6a591a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/plugins/org.eclipse.elk.core/src/org/eclipse/elk/core/util/persistence/ElkGraphResource.java b/plugins/org.eclipse.elk.core/src/org/eclipse/elk/core/util/persistence/ElkGraphResource.java
@@ -33,7 +33,7 @@
  * 
  * <h3>Deserialization</h3>
  * 
- * <p>Deserializing properties requries the
+ * <p>Deserializing properties requires the
  * {@link org.eclipse.elk.core.data.LayoutMetaDataService LayoutMetaDataService} to obtain appropriate
  * {@link org.eclipse.elk.core.data.LayoutOptionData LayoutOptionData} objects to be able to parse option
  * values. This cannot be done in the graph plug-in with the graph factory's conversion methods, since the

diff --git a/plugins/org.eclipse.elk.core/src/org/eclipse/elk/core/util/persistence/ElkGraphXMISave.java b/plugins/org.eclipse.elk.core/src/org/eclipse/elk/core/util/persistence/ElkGraphXMISave.java
@@ -48,7 +48,7 @@ protected void saveElement(final EObject o, final EStructuralFeature f) {
 
             // Check if the value we want to serialize here will be parsable later so we can deserialize it
             // again properly; if this is not the case, there is no point serializing it in the first place
-            if (optionData != null && !optionData.canParseValue()) {
+            if (optionData == null || (optionData != null && !optionData.canParseValue())) {
                 return;
             }
         }