Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add prometheus, simplify server logging #74

Merged
merged 14 commits into from
Jan 29, 2024
Merged

add prometheus, simplify server logging #74

merged 14 commits into from
Jan 29, 2024

Conversation

c-cube
Copy link
Member

@c-cube c-cube commented Jan 23, 2024 •
edited
Loading

I've been updating https://benchpress.cedeela.fr/ and did some changes:

  • metrics via prometheus
  • fix segfaults occurring via sqlite (do a fold ourselves, not via a sqlite aggregation function)
  • systemd-friendly logger for the server

@c-cube c-cube requested a review from hra687261 January 25, 2024 03:23
hra687261
hra687261 approved these changes Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@hra687261 hra687261 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c-cube c-cube merged commit 2cbd334 into master Jan 29, 2024
2 checks passed
@c-cube c-cube deleted the wip-prometheus branch January 29, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hra687261 hra687261 hra687261 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-cube @hra687261