Add detailed statistics for the subcommand show
#73
Conversation
It is useful to know how long solvers took to answer `sat`, `unsat` and `unknown`. In this PR, benchpress outputs more statistics for these answers while using the subcommand `show`.
|
I will add an option to toggle detailed statistics. Otherwise the CI cannot succeed. |
src/core/Test_stat.ml
Outdated
| vlist | ||
| [ | ||
| pb_int_color c n; | ||
| grid |
There was a problem hiding this comment.
this is not wrong, but I think PB.record could be easier :)
Co-authored-by: Simon Cruanes <simon.cruanes.2007@m4x.org>
- Using `v_record` to print the details table. - Add a CLI option to enable the feature.
|
Hu, I didn't realize it was that portable, my bad.
|
|
No sure what the segfault is about, any idea? |
|
I can reproduce the bug on OCaml 4.08. I'll investigate. |
|
Bad news. The bug is localized in the bindings library I didn't notice that you reported the issue ;p |
|
Oh yeah. Ok we can bump the minimal version.
|
The bindings library `sqlite3` contains a bug concerning aggregate functions which has been fixed in its release `5.0.3` but this release requires at least OCaml `4.12`.
|
Sorry, I thought that you're going to bump the minimal version in a separated PR. I did it in the last commit of this PR. Notice that I modified by myself the opam files as it seems you don't use |
|
Can you edit the github workflow to use 4.12 and 5.0 as OCaml versions? |
Testing benchpress with OCaml version 4.12 an OCaml version 5.0
|
Thank you! :) |
It is useful to know how long solvers took to answer
sat,unsatandunknown. In this PR, benchpress outputs more statistics for these answers while using the subcommandshow.I also add a
.editorconfig;)