Only remove/add targets to new filter group if needed

smule · Aug 2, 2017 · 856d7a8 · 856d7a8
1 parent fd31a9c
commit 856d7a8
Showing 1 changed file with 13 additions and 10 deletions.
diff --git a/Source/PBJVision.m b/Source/PBJVision.m
@@ -2795,21 +2795,24 @@ - (void)_renderSampleBuffer:(CMSampleBufferRef)sampleBuffer
             // Update current filter group if needed
             if ((int)self.currentFilterType != _lastFilterType || self.airbrushFilterType != _lastAirbrushFilterType)
             {
-                [_movieDataInput removeTarget:_currentFilterGroup];
-                [_currentFilterGroup removeAllTargets];
+                GPUImageOutput<GPUImageInput> *newFilterGroup = [_filterManager filterWithType:self.currentFilterType airbrushFilterType:self.airbrushFilterType];
 
-                _currentFilterGroup = [_filterManager filterWithType:self.currentFilterType airbrushFilterType:self.airbrushFilterType];
-
-                [_movieDataInput addTarget:_currentFilterGroup];
-                [_currentFilterGroup addTarget:_filteredPreviewView];
+                // Check if the filter needs to be changed
+                if (![[_movieDataInput targets] containsObject:newFilterGroup])
+                {
+                    [_movieDataInput removeTarget:_currentFilterGroup];
+                    [_currentFilterGroup removeAllTargets];
+
+                    _currentFilterGroup = newFilterGroup;
+
+                    [_movieDataInput addTarget:_currentFilterGroup];
+                    [_currentFilterGroup addTarget:_filteredPreviewView];
+                }
 
                 _lastFilterType = self.currentFilterType;
                 _lastAirbrushFilterType = self.airbrushFilterType;
-
-
+
             }
-
-
             [_currentFilterGroup setInputRotation:rotation atIndex:0];
         }
         else