Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor smithy-rules-engine #1855

Merged
merged 23 commits into from
Sep 19, 2023
Merged

Refactor smithy-rules-engine #1855

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
ac81bc0
Significant refactoring of smithy-rules-engine
kstich Feb 28, 2023
3b95408
Enable RuleSet and Test validation by default
kstich May 24, 2023
7e4d9fd
Add validation of endpoint test operation inputs
kstich May 27, 2023
504eac0
Continued refactoring of smithy-rules-engine
kstich Jun 1, 2023
671b384
Refactor rules engine functions
kstich Jun 8, 2023
0b1f8b7
Extract AWS specific rules engine functions
kstich Jun 14, 2023
d47e8e8
Update license headers
kstich Jun 14, 2023
635b8da
Add javadoc and clean up public interfaces
kstich Jun 21, 2023
c4d3a20
Address CR Feedback
kstich Jun 22, 2023
b7501ec
Extract AWS built-ins and auth validation
kstich Jun 27, 2023
36ce65d
Address more CR feedback
kstich Jun 27, 2023
1bcb819
Add rules-engine specifications
kstich Jul 5, 2023
ded900b
Improve in-code function composition
kstich Jul 17, 2023
1e97bc3
Allow disableNormalizePath for sigv4/sigv4a
kstich Jul 18, 2023
335d04c
Add ModelTransformerPlugin for endpoint test cases
kstich Jul 26, 2023
3775422
Refactor EndpointRuleSetExtension SPI loading
kstich Jul 26, 2023
d41ec7a
Move AWS content to smithy-aws-endpoints
kstich Aug 8, 2023
f0c179a
Fix issues validating rule/test params
kstich Aug 11, 2023
e988a86
Add ImplicitGlobalRegion to Partition output (#1921)
alextwoods Aug 17, 2023
ee526b7
Improve in-code rule-set composition
kstich Aug 30, 2023
5575572
Remove deprecated NumberNode method use
kstich Sep 6, 2023
67c625f
Add test cases to isValidHostLabel and isVirtualHostableS3Bucket
alextwoods Sep 13, 2023
587a578
Allow non-builtIn params to have default values
kstich Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update license headers
  • Loading branch information
@kstich
kstich committed Sep 6, 2023
commit d47e8e848f9f59f5faadbfde0cfd4df8a8a4144f
14 changes: 2 additions & 12 deletions ...ngine/src/main/java/software/amazon/smithy/aws/rulesengine/language/functions/AwsArn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.aws.rulesengine.language.functions;
Expand Down
14 changes: 2 additions & 12 deletions ...ftware/amazon/smithy/aws/rulesengine/language/functions/AwsIsVirtualHostableS3Bucket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.aws.rulesengine.language.functions;
Expand Down
14 changes: 2 additions & 12 deletions ...src/main/java/software/amazon/smithy/aws/rulesengine/language/functions/AwsPartition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.aws.rulesengine.language.functions;
Expand Down
14 changes: 2 additions & 12 deletions ...ine/src/main/java/software/amazon/smithy/aws/rulesengine/language/functions/ParseArn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.aws.rulesengine.language.functions;
Expand Down
14 changes: 2 additions & 12 deletions ...zon/smithy/aws/rulesengine/language/functions/partition/DefaultPartitionDataProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.aws.rulesengine.language.functions.partition;
Expand Down
14 changes: 2 additions & 12 deletions ...n/java/software/amazon/smithy/aws/rulesengine/language/functions/partition/Partition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.aws.rulesengine.language.functions.partition;
Expand Down
14 changes: 2 additions & 12 deletions ...are/amazon/smithy/aws/rulesengine/language/functions/partition/PartitionDataProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.aws.rulesengine.language.functions.partition;
Expand Down
14 changes: 2 additions & 12 deletions ...software/amazon/smithy/aws/rulesengine/language/functions/partition/PartitionOutputs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.aws.rulesengine.language.functions.partition;
Expand Down
14 changes: 2 additions & 12 deletions .../java/software/amazon/smithy/aws/rulesengine/language/functions/partition/Partitions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.aws.rulesengine.language.functions.partition;
Expand Down
14 changes: 2 additions & 12 deletions ...a/software/amazon/smithy/aws/rulesengine/language/functions/partition/RegionOverride.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.aws.rulesengine.language.functions.partition;
Expand Down
15 changes: 0 additions & 15 deletions ...e/src/test/java/software/amazon/smithy/aws/rulesengine/language/functions/AwsArnTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,3 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

package software.amazon.smithy.aws.rulesengine.language.functions;

import static org.junit.jupiter.api.Assertions.assertEquals;
Expand Down
15 changes: 0 additions & 15 deletions ...a/software/amazon/smithy/aws/rulesengine/language/functions/AwsPartitionFunctionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,3 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

package software.amazon.smithy.aws.rulesengine.language.functions;

import static org.hamcrest.CoreMatchers.equalTo;
Expand Down
15 changes: 0 additions & 15 deletions .../test/java/software/amazon/smithy/aws/rulesengine/language/functions/IntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,3 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

package software.amazon.smithy.aws.rulesengine.language.functions;

import static org.junit.jupiter.api.Assertions.assertEquals;
Expand Down
15 changes: 0 additions & 15 deletions ...a/software/amazon/smithy/aws/rulesengine/language/functions/partition/PartitionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,3 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

package software.amazon.smithy.aws.rulesengine.language.functions.partition;

import static org.hamcrest.MatcherAssert.assertThat;
Expand Down
14 changes: 2 additions & 12 deletions smithy-rules-engine/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

description = "Smithy rules engine Language and traits"
Expand Down
14 changes: 2 additions & 12 deletions ...les-engine/src/main/java/software/amazon/smithy/rulesengine/analysis/CoverageChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.rulesengine.analysis;
Expand Down
14 changes: 2 additions & 12 deletions smithy-rules-engine/src/main/java/software/amazon/smithy/rulesengine/language/Endpoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.rulesengine.language;
Expand Down
14 changes: 2 additions & 12 deletions ...les-engine/src/main/java/software/amazon/smithy/rulesengine/language/EndpointRuleSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.rulesengine.language;
Expand Down
14 changes: 2 additions & 12 deletions ...s-engine/src/main/java/software/amazon/smithy/rulesengine/language/TraversingVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.rulesengine.language;
Expand Down
14 changes: 2 additions & 12 deletions ...gine/src/main/java/software/amazon/smithy/rulesengine/language/error/InnerParseError.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.rulesengine.language.error;
Expand Down
14 changes: 2 additions & 12 deletions ...rc/main/java/software/amazon/smithy/rulesengine/language/error/InvalidRulesException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
/*
* Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

package software.amazon.smithy.rulesengine.language.error;
Expand Down
Loading