Remove suppressing internal tagged enum shape members #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
restJson1validation protocol tests so thatinternaltagged enums shape members are no longer suppressed from the validation message. Only enum shape members tagged with the@internaltrait are suppressed from a validation message.Enum traits that are tagged as "internal" are still expected to be suppressed from the validation message, as traits cannot be applied to an enum trait definition, leaving the "internal" tag as the only way to suppress an enum value from the validation message.
See #1737.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.