Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return internal enum values #1658

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Do not return internal enum values #1658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions smithy-aws-protocol-tests/model/restJson1/validation/malformed-enum.smithy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ apply MalformedEnum @httpMalformedRequestTests([
id: "RestJsonMalformedEnumString",
documentation: """
When a string member does not contain a valid enum value,
the response should be a 400 ValidationException.""",
the response should be a 400 ValidationException. Internal-only
enum values are excluded from the response message.""",
protocol: restJson1,
request: {
method: "POST",
Expand Down Expand Up @@ -51,7 +52,8 @@ apply MalformedEnum @httpMalformedRequestTests([
id: "RestJsonMalformedEnumList",
documentation: """
When a list member value does not contain a valid enum value,
the response should be a 400 ValidationException.""",
the response should be a 400 ValidationException. Internal-only
enum values are excluded from the response message.""",
protocol: restJson1,
request: {
method: "POST",
Expand Down Expand Up @@ -84,7 +86,8 @@ apply MalformedEnum @httpMalformedRequestTests([
id: "RestJsonMalformedEnumMapKey",
documentation: """
When a map member's key does not contain a valid enum value,
the response should be a 400 ValidationException.""",
the response should be a 400 ValidationException. Internal-only
enum values are excluded from the response message.""",
protocol: restJson1,
request: {
method: "POST",
Expand Down Expand Up @@ -117,7 +120,8 @@ apply MalformedEnum @httpMalformedRequestTests([
id: "RestJsonMalformedEnumMapValue",
documentation: """
When a map member's value does not contain a valid enum value,
the response should be a 400 ValidationException.""",
the response should be a 400 ValidationException. Internal-only
enum values are excluded from the response message.""",
protocol: restJson1,
request: {
method: "POST",
Expand Down Expand Up @@ -150,7 +154,8 @@ apply MalformedEnum @httpMalformedRequestTests([
id: "RestJsonMalformedEnumUnion",
documentation: """
When a union member's value does not contain a valid enum value,
the response should be a 400 ValidationException.""",
the response should be a 400 ValidationException. Internal-only
enum values are excluded from the response message.""",
protocol: restJson1,
request: {
method: "POST",
Expand Down Expand Up @@ -194,6 +199,12 @@ structure MalformedEnumInput {
enum EnumString {
ABC = "abc"
DEF = "def"

@internal
GHI = "ghi"

@tags(["internal"])
JKL = "jkl"
}

list EnumList {
Expand Down