Add validation to validator and suppression ids #1344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
reviewed
Aug 11, 2022
Prior, validator ids / names and the suppressions from metadata were not constrained by any language, while the suppression trait pattern was overly constrained. This commit ensures validators and suppressions share the same ABNF in the following places: - `validators` metadata - `suppressions` metadata - `@suppress` trait Updated the documentation for the Validation Event ID ABNF to reflect these changes and also use camelcase tokens (included changes in Shape ID documentation for consistency). Fixed bugs in the ShapeId namespace code: - StringIndexOutOfBoundsException thrown for cases like "___". - Mismatch in `IdentifierStart` parsing compared to ABNF Resolves smithy-lang#987
syall
force-pushed
the
validator-suppress-id-mismatch
branch
from
647a5f5 to
e8f459c
Compare
|
Closing based on #987 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#987
Description of changes:
Prior, validator ids / names and the suppressions from metadata
were not constrained by any language, while the suppression trait
pattern was overly constrained.
This commit ensures validators and suppressions share the same ABNF
in the following places:
validatorsmetadatasuppressionsmetadata@suppresstraitUpdated the documentation for the Validation Event ID ABNF to
reflect these changes and also use camelcase tokens (included
changes in Shape ID documentation for consistency).
Fixed bugs in the ShapeId namespace code:
StringIndexOutOfBoundsException thrown for cases like "___".
Mismatch in
IdentifierStartparsing compared to ABNFTesting:
Ran
./gradlew clean build check assemble --parallel --no-build-cache --no-daemonBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.