for mozilla#251: some review fixups

smileys2 · Aug 10, 2018 · ed4674a · ed4674a
1 parent 2646125
commit ed4674a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/db/DB.js b/db/DB.js
@@ -28,7 +28,7 @@ const DB = {
     return res[0];
   },
 
-  async verifyEmailHash(token, email) {
+  async verifyEmailHash(token) {
     const unverifiedSubscriber = await this.getSubscriberByToken(token);
     const verifiedSubscriber = await this._verifySubscriber(unverifiedSubscriber);
     return verifiedSubscriber[0];

diff --git a/email-utils.js b/email-utils.js
@@ -76,7 +76,7 @@ const EmailUtils = {
 
     return new Promise((resolve, reject) => {
       gTransporter.use("compile", hbs(hbsOptions));
-      const emailFrom = AppConstants.EMAIL_FROM || `"Firefox Monitor" < ${kSMTPUsername}`;
+      const emailFrom = AppConstants.EMAIL_FROM || `"Firefox Monitor" <${kSMTPUsername}>`;
       const mailOptions = {
         from: emailFrom,
         to: aRecipient,

diff --git a/routes/user.js b/routes/user.js
@@ -49,7 +49,7 @@ router.post("/add", urlEncodedParser, async (req, res) => {
 });
 
 router.get("/verify", jsonParser, async (req, res) => {
-  const verifiedEmailHash = await DB.verifyEmailHash(req.query.token, req.query.email);
+  const verifiedEmailHash = await DB.verifyEmailHash(req.query.token);
   if (!verifiedEmailHash) {
     res.status(400).json({
       error_code: ResponseCodes.EmailNotFound,