Reroute and update breach details pages. WIP.

smileys2 · May 6, 2019 · 03a3714 · 03a3714
1 parent 9926ada
commit 03a3714
Show file tree

Hide file tree

Showing 5 changed files with 46 additions and 11 deletions.
diff --git a/controllers/breach-details.js b/controllers/breach-details.js
@@ -0,0 +1,23 @@
+"use strict";
+
+const HIBP = require("../hibp");
+
+function getBreachDetail(req, res) {
+
+  const allBreaches = req.app.locals.breaches;
+
+  const breachName = req.params.breachName;
+  const featuredBreach = HIBP.getBreachByName(allBreaches, breachName);
+
+  if (!featuredBreach) {
+    res.redirect("/");
+  }
+
+  res.render("breach-detail", {
+    featuredBreach,
+  });
+}
+
+module.exports = {
+  getBreachDetail,
+};
diff --git a/controllers/home.js b/controllers/home.js
@@ -34,7 +34,7 @@ async function home(req, res) {
     }
     scanFeaturedBreach = true;
 
-    return res.render("breach-detail", {
+    return res.render("monitor", {
       title: req.fluentFormat("home-title"),
       featuredBreach: featuredBreach,
       scanFeaturedBreach,

diff --git a/routes/breach-details.js b/routes/breach-details.js
@@ -0,0 +1,10 @@
+"use strict";
+
+const express = require("express");
+const { getBreachDetail } = require("../controllers/breach-details");
+const router = express.Router();
+
+
+router.get("/:breachName", getBreachDetail);
+
+module.exports = router;
diff --git a/server.js b/server.js
@@ -29,6 +29,7 @@ const SesRoutes = require("./routes/ses");
 const OAuthRoutes = require("./routes/oauth");
 const UserRoutes = require("./routes/user");
 const EmailL10nRoutes= require("./routes/email-l10n");
+const BreachRoutes= require("./routes/breach-details");
 
 const log = mozlog("server");
 const app = express();
@@ -172,6 +173,7 @@ app.use("/scan", ScanRoutes);
 app.use("/ses", SesRoutes);
 app.use("/user", UserRoutes);
 (devOrHeroku ? app.use("/email-l10n", EmailL10nRoutes) : null);
+app.use("/breach-details", BreachRoutes);
 app.use("/", HomeRoutes);
 
 app.use(logErrors);

diff --git a/template-helpers/breach-detail.js b/template-helpers/breach-detail.js
@@ -85,22 +85,22 @@ function getSensitiveBreachContent(locales, breach) {
 function getTips(locales, breach) {
   const tips = [
     {
-      title: "create-pw",
-      subtitle: "strength-of-your",
-      linkTitle: "how-to-create",
-      href: "/create-strong-passwords",
+      title: "stop-reusing-pw",
+      subtitle: "create-unique-pw",
+      linkTitle: "five-myths",
+      href: "",
     },
     {
-      title: "stop-using",
-      subtitle: "get-help-managing",
-      linkTitle: "why-password-managers",
-      href: "/password-managers",
+      title: "make-new-pw-unique",
+      subtitle: "strength-of-your-pw",
+      linkTitle: "create-strong-passwords",
+      href: "",
     },
     {
       title: "change-pw",
       subtitle: "even-for-old",
-      linkTitle: "what-to-do-after",
-      href: "/what-to-do",
+      linkTitle: "what-to-do-after-breach",
+      href: "",
     },
   ];
   tips.forEach(tip => {