Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AM-147] Node setup #80

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[AM-147] Node setup #80

wants to merge 3 commits into from

Conversation

rtrvrtg
Copy link
Collaborator

@rtrvrtg rtrvrtg commented Aug 20, 2021 •
edited
Loading

AM-147

  • Ensure Ruby dependencies
    • Update where available
  • Ensure node dependencies
    • Switch from node-sass to sass
    • Ensure dotenv because we need it for speech-to-text script
  • Capistrano changes
    • Symlink .env from shared
    • Run node install during deploy

@rtrvrtg rtrvrtg marked this pull request as ready for review August 20, 2021 05:28
rodrigoassis
rodrigoassis approved these changes Aug 20, 2021
View reviewed changes
Copy link

@rodrigoassis rodrigoassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to update Gemfile or Gemfile.lock from my understanding

Also, is it necessary to add sass package in package.json?

Other than that, LGTM

@rtrvrtg
Copy link
Collaborator Author

rtrvrtg commented Mar 29, 2023

I think I'll do a second pass at this after the Ruby updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigoassis rodrigoassis rodrigoassis approved these changes

@helloyounglionsxo helloyounglionsxo Awaiting requested review from helloyounglionsxo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtrvrtg @rodrigoassis