Fixing comments for ClientCredentialType tests.

sll97163 · Sep 23, 2015 · 0a6487f · 0a6487f
1 parent fb9eedb
commit 0a6487f
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/....ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeTests.cs b/....ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeTests.cs
@@ -10,7 +10,9 @@
 public static class Tcp_ClientCredentialTypeTests
 {
     // Simple echo of a string using NetTcpBinding on both client and server with all default settings.
-    // Default settings means SecurityMode is set to Transport.
+    // Default settings are:
+    //                         - SecurityMode = Transport
+    //                         - ClientCredentialType = Windows
     [Fact]
     [ActiveIssue(300)]
     [OuterLoop]
@@ -37,7 +39,7 @@ public static void SameBinding_DefaultSettings_EchoString()
         }
     }
 
-    // Simple echo of a string using NetTcpBinding on both client and server with all default settings.
+    // Simple echo of a string using NetTcpBinding on both client and server with SecurityMode=None
     [Fact]
     [OuterLoop]
     public static void SameBinding_SecurityModeNone_EchoString()
@@ -63,6 +65,7 @@ public static void SameBinding_SecurityModeNone_EchoString()
     }
 
     // Simple echo of a string using NetTcpBinding on both client and server with SecurityMode=Transport
+    // By default ClientCredentialType will be 'Windows'
     [Fact]
     [ActiveIssue(300)]
     [OuterLoop]
@@ -88,7 +91,8 @@ public static void SameBinding_SecurityModeTransport_EchoString()
         }
     }
 
-    // Simple echo of a string using NetTcpBinding on both client and server with SecurityMode=Transport
+    // Simple echo of a string using a CustomBinding to mimic a NetTcpBinding with Security.Mode = TransportWithMessageCredentials
+    // This does not exactly match the binding elements in a NetTcpBinding which also includes a TransportSecurityBindingElement
     [Fact]
     [ActiveIssue(310)]
     [OuterLoop]
@@ -100,7 +104,7 @@ public static void SameBinding_SecurityModeTransport_ClientCredentialTypeCertifi
         try
         {
             CustomBinding binding = new CustomBinding(
-                new SslStreamSecurityBindingElement(),
+                new SslStreamSecurityBindingElement(), // This is the binding element used when Security.Mode  = TransportWithMessageCredentials
                 new BinaryMessageEncodingBindingElement(),
                 new TcpTransportBindingElement());