Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slintpad: Move into tools/slintpad #2435

Merged
merged 2 commits into from
Mar 29, 2023
Merged

slintpad: Move into tools/slintpad #2435

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0407b58
slintpad: Move into tools/slintpad
hunger Mar 29, 2023
3a9ea91
Apply suggestions from code review
hunger Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Olivier Goffart <olivier@woboq.com>
  • Loading branch information
@hunger @ogoffart
hunger and ogoffart authored Mar 29, 2023
commit 3a9ea91a44e546f8f7f463fbccf2078aa2224540
6 changes: 3 additions & 3 deletions .github/actions/test-online-editor/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
# https://github.com/cypress-io/cypress-realworld-app/blob/develop/.github/workflows/main.yml

---
name: Test slintpad (cypress)
description: Test the slintpad using cypress
name: Test Slintpad (cypress)
description: Test Slintpad using cypress

inputs:
browser:
Expand All @@ -20,7 +20,7 @@ inputs:
required: true
default: wasm
slintpad-artifact:
description: "The slintpad artifacts"
description: "The Slintpad artifacts"
required: true
default: slintpad

Expand Down
2 changes: 1 addition & 1 deletion internal/compiler/expression_tree.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ impl BuiltinFunction {
BuiltinFunction::ColorBrighter | BuiltinFunction::ColorDarker => true,
// ImageSize is pure, except when loading images via the network. Then the initial size will be 0/0 and
// we need to make sure that calls to this function stay within a binding, so that the property
// notification when updating kicks in. Only slintpad (wasm-interpreter) loads images via the network,
// notification when updating kicks in. Only Slintpad (wasm-interpreter) loads images via the network,
// which is when this code is targeting wasm.
#[cfg(not(target_arch = "wasm32"))]
BuiltinFunction::ImageSize => true,
Expand Down
2 changes: 1 addition & 1 deletion tools/slintpad/src/worker/lsp_worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ slint_init()
const response = the_lsp.server_initialize_result(
params.capabilities,
);
response.capabilities.codeLensProvider = null; // CodeLenses are not relevant for the slintpad
response.capabilities.codeLensProvider = null; // CodeLenses are not relevant for Slintpad
return response;
},
);
Expand Down