use twitter handle in shares

slidr-app · Jul 3, 2023 · c17510f · c17510f
1 parent 640da45
commit c17510f
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 4 deletions.
diff --git a/functions/src/presentation.d.ts b/functions/src/presentation.d.ts
@@ -1,13 +1,17 @@
 export type Doc = {
   id: string;
 };
+
+// TODO: use this when uploading
 export type PresentationData = {
   title: string;
   thumb: string;
   pages: string[];
   notes: Note[];
   uid: string;
   username: string;
+  // TODO: use this in function metadata
+  twitterHandle: string;
   thumbIndex?: number;
 };
 export type PresentationDoc = Doc & PresentationData;

diff --git a/src/components/Shares.tsx b/src/components/Shares.tsx
@@ -14,9 +14,20 @@ export default function Shares({
     slideIndex + 1
   }`;
 
-  const tweetText = `${presentation?.title ?? 'preentation'}${
-    presentation?.username === undefined ? '' : ' by ' + presentation.username
-  } ${shareUrl}`;
+  const tweetText =
+    presentation === undefined
+      ? ''
+      : `${
+          presentation.title.length > 0 ? presentation.title : 'presentation'
+        }${
+          presentation.username.length > 0 ? ' by ' + presentation.username : ''
+        }${
+          // TODO: make the twitter handle required in the rules and set it to an empty string on upload
+          // Then remove the ?? '' below
+          (presentation.twitterHandle ?? '').length > 0
+            ? ' ' + presentation.twitterHandle
+            : ''
+        } ${shareUrl}`;
 
   const [copied, setCopied] = useState(false);
   useEffect(() => {

diff --git a/src/pages/Viewer.tsx b/src/pages/Viewer.tsx
@@ -121,7 +121,10 @@ export default function Viewer() {
             <div>{presentation?.title ?? ''}</div>
             {presentation && (
               <div className="text-base">
-                by {presentation.username ?? 'Anonymous User'}
+                by{' '}
+                {presentation.username.length > 0
+                  ? presentation.username
+                  : 'Anonymous User'}
               </div>
             )}
           </div>