Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SurfaceType to flags #4616

Merged
merged 14 commits into from
Dec 2, 2018

Conversation

supermerill
Copy link
Collaborator

@supermerill supermerill commented Nov 27, 2018

from #4553 (comment)

Tested on a simple object.

@AppVeyorBot
Copy link

@supermerill supermerill force-pushed the alexrj_flagssurfacetype branch from 7abb15a to 040be5f Compare November 27, 2018 16:32
@supermerill
Copy link
Collaborator Author

It compiles on my pc...
Well, even the master doesn't compile.
I'll wait until the master compile on travis.

@AppVeyorBot
Copy link

Build Slic3r 1.3.0-master-2099 failed (commit c315721e8f by @)

@AppVeyorBot
Copy link

Build Slic3r 1.3.0-master-2103 failed (commit 5e7f1da782 by @)

@AppVeyorBot
Copy link

Build Slic3r 1.3.0-master-2107 failed (commit 6150a92f1b by @)

@AppVeyorBot
Copy link

Build Slic3r 1.3.0-master-2108 failed (commit 096ed9260c by @)

more () for protection for the operator |
@AppVeyorBot
Copy link

Build Slic3r 1.3.0-master-2109 failed (commit de2ada76ef by @)

@AppVeyorBot
Copy link

Build Slic3r 1.3.0-master-2110 failed (commit f5c0406ced by @)

@AppVeyorBot
Copy link

Build Slic3r 1.3.0-master-2112 failed (commit f677223cf0 by @)

@supermerill
Copy link
Collaborator Author

supermerill commented Nov 29, 2018

wooot!
Now only 1 test failing : t/fill.t: "infill is only generated under the forced solid shells"
Someone know what piece of code is tested by that?

@supermerill
Copy link
Collaborator Author

Should be ok now.
You can review it.

@AppVeyorBot
Copy link

Build Slic3r 1.3.0-master-2116 completed (commit e5bb288a6e by @)

@lordofhyphens lordofhyphens merged commit 6d0d6d5 into slic3r:master Dec 2, 2018
lordofhyphens added a commit that referenced this pull request Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants