Deflate amf #4528
Closed
Deflate amf #4528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes basic tests. Implements slic3r#4511
|
@Artefact2 can you give this a spin and see how it works for you? If you find issues with loading, let me know and I can extend the tests to cover. The current known limitation is that you are only allowed 1 deflated file in the archive, but it can be in a subdirectory. |
|
Sadly I wasn't able to import a quick .amf test export from FreeCAD with your changes. Slic3r Edit:
|
|
✅ Build Slic3r 1.3.0-master-2482 completed (commit 851ac25787 by @lordofhyphens) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #4511 with tests.