Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to load invalid config bundle causes crash #4783

Open
tkircher opened this issue Apr 12, 2019 · 7 comments
Open

Trying to load invalid config bundle causes crash #4783

tkircher opened this issue Apr 12, 2019 · 7 comments

Comments

@tkircher
Copy link

Version
slic3r-1.3.1-dev-5361240-osx.dmg

Description
Trying to load an improperly formed config bundle causes an immediate crash

Operating system
MacOS 10.12.6

File in question
0.4.4.txt

@lordofhyphens
Copy link
Member

@tkircher I just merged #4765 which may address this.

@lordofhyphens
Copy link
Member

At least with the crash, anyway.

@tkircher
Copy link
Author

I'll check it out and report back. Thanks!

@tkircher
Copy link
Author

Still crashes with slic3r-1.3.1-dev-5f68ce4-osx.dmg.

@lordofhyphens
Copy link
Member

Ah, that's probably because you are trying to load a Prusa3d config bundle and the config loader got more strict about what it accepts (and we hadn't done the error handling to adapt).

@lordofhyphens
Copy link
Member

lordofhyphens commented Apr 13, 2019

I am not experienced enough in Perl to handle that error.
I tried to wrap the call in an eval {} but it still threw the exception and it apparently wasn't caught.

@tkircher
Copy link
Author

Ah, that's probably because you are trying to load a Prusa3d config bundle and the config loader got more strict about what it accepts (and we hadn't done the error handling to adapt).

Even if I'm trying to load a PNG accidentally, the parser either accepts or rejects. Crashing is always a bug. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants