Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug where parsing assistant thread message event fails for beta feature enabled apps #1389

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix a bug where parsing assistant thread message event fails for beta feature enabled apps #1389

merged 1 commit into from
Oct 22, 2024
+33 −2

Conversation

seratch
Copy link
Member

@seratch seratch commented Oct 22, 2024

This pull request resolves a bug where parsing assistant thread message event fails for beta feature enabled apps.
See also: slackapi/bolt-python#1184

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:bolt labels Oct 22, 2024
@seratch seratch added this to the 1.44.1 milestone Oct 22, 2024
@seratch seratch self-assigned this Oct 22, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.65%. Comparing base (de2b9e2) to head (98c8a6a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...om/slack/api/bolt/util/EventsApiPayloadParser.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1389      +/-   ##
============================================
- Coverage     73.98%   73.65%   -0.34%     
- Complexity     4376     4379       +3     
============================================
  Files           476      476              
  Lines         13785    14108     +323     
  Branches       1421     1423       +2     
============================================
+ Hits          10199    10391     +192     
- Misses         2754     2884     +130     
- Partials        832      833       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch force-pushed the assistant-user-message branch from fe5443d to 98c8a6a Compare October 22, 2024 05:53
@seratch seratch merged commit 096b344 into slackapi:main Oct 22, 2024
6 checks passed
@seratch seratch deleted the assistant-user-message branch October 22, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@seratch seratch

Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:bolt
Projects
None yet
Milestone
1.44.1
Development

Successfully merging this pull request may close these issues.
1 participant
@seratch