Fix #545 Enable to use lazy listeners even when having any custom context data #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stom context data
Codecov Report
@@ Coverage Diff @@
## main #546 +/- ##
==========================================
+ Coverage 91.29% 91.33% +0.04%
==========================================
Files 169 169
Lines 5606 5635 +29
==========================================
+ Hits 5118 5147 +29
Misses 488 488
Continue to review full report at Codecov.
|
|
Although “copiable” seems to be an accepted variant, a Google Ngram search shows “copyable” is more commonly used. I bring this up because if somebody greps the code for “copy”, naming the methods Just a small observation (functionally the code looks OK to me 🙂) |
|
@eddyg Thanks! I'm happy to rename it 👍 |
|
Renamed the methods |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #545 by enhancing the internals of lazy listener execution mechanism.
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.