Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor galaxy photometry from kcorrect templates #386

Merged
merged 22 commits into from
Jan 19, 2021
Merged

Refactor galaxy photometry from kcorrect templates #386

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
c8f4435
Galaxy photometry using kcorrect spectrum templates
rrjbca Dec 1, 2020
bd01959
kcorrect template data
rrjbca Dec 1, 2020
ae3a246
kcorrect license
rrjbca Dec 1, 2020
04dc940
Fix typos
rrjbca Dec 3, 2020
79b5efe
Refactor kcorrect absolute and apparent magnitude calculations
rrjbca Dec 22, 2020
5069a20
Refactor stellar mass calculation for kcorrect templates
rrjbca Dec 23, 2020
414df2e
Refactor mag_ab to return fluxes of templates
rrjbca Dec 23, 2020
a93ffdd
Refactor unit tests for ab_maggies_redshift
rrjbca Jan 5, 2021
6947a9b
Update spectrum module function list in documentation
rrjbca Jan 5, 2021
578c060
Factor out generalised template magnitude functions
rrjbca Jan 12, 2021
e2e2092
Docstrings for template functions
rrjbca Jan 18, 2021
382d95f
Fix docstring for ab_maggies_redshift
rrjbca Jan 18, 2021
6354cec
Refactor test_kcorrect_stellar_mass
rrjbca Jan 18, 2021
eda94db
Merge branch 'master' into kcorrect
rrjbca Jan 18, 2021
eea828c
test_kcorrect_magnitudes
rrjbca Jan 18, 2021
175197d
Fix failing tests
rrjbca Jan 18, 2021
728d608
Test incorrect number of coefficients raises an exception
rrjbca Jan 18, 2021
fb561f9
Revert mag_ab; fix handling of coefficients
rrjbca Jan 18, 2021
2a74d6d
Fix stellar_mass parameter; add unit tests
rrjbca Jan 18, 2021
1a73608
GalaxyTemplateBase and kcorrect classes
rrjbca Jan 18, 2021
5b2881b
kcorrect is an instance of KCorrectTemplates class
rrjbca Jan 19, 2021
76a214d
Abstract method is NotImplemented for purpose of test coverage
rrjbca Jan 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update spectrum module function list in documentation
  • Loading branch information
@rrjbca
rrjbca committed Jan 5, 2021
commit 6947a9bd7d2e055491ab5e1f8a3e430f066f1eb7
6 changes: 4 additions & 2 deletions docs/galaxy.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,10 @@ The following models are found in the `skypy.galaxy.spectrum` package.

dirichlet_coefficients
load_spectral_data
mag_ab
magnitudes_from_templates
ab_maggies_redshift
kcorrect_absolute_magnitudes
kcorrect_apparent_magnitudes
kcorrect_stellar_mass


Stellar mass
Expand Down