fix websocket handshake failure causes an exception

sjtuldl · Sep 22, 2017 · 5d4a9ab · 5d4a9ab
1 parent 34c43f4
commit 5d4a9ab
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/tornado/test/websocket_test.py b/tornado/test/websocket_test.py
@@ -193,6 +193,13 @@ def test_http_request(self):
         response = self.fetch('/echo')
         self.assertEqual(response.code, 400)
 
+    def test_missing_websocket_key(self):
+        response = self.fetch('/echo',
+                              headers={'Connection': 'Upgrade',
+                                       'Upgrade': 'WebSocket',
+                                       'Sec-WebSocket-Version': '13'})
+        self.assertEqual(response.code, 400)
+
     def test_bad_websocket_version(self):
         response = self.fetch('/echo',
                               headers={'Connection': 'Upgrade',

diff --git a/tornado/websocket.py b/tornado/websocket.py
@@ -616,6 +616,14 @@ def __init__(self, handler, mask_outgoing=False,
     def accept_connection(self):
         try:
             self._handle_websocket_headers()
+        except ValueError:
+            self.handler.set_status(400)
+            log_msg = "Missing/Invalid WebSocket headers"
+            self.handler.finish(log_msg)
+            gen_log.debug(log_msg)
+            return
+
+        try:
             self._accept_connection()
         except ValueError:
             gen_log.debug("Malformed WebSocket request received",