Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Remove redundant code #36

Merged
merged 2 commits into from
Oct 9, 2018
Merged

Remove redundant code #36

merged 2 commits into from
Oct 9, 2018

Conversation

itaisteinherz
Copy link
Contributor

It has already been implemented in sindresorhus/got#584. (like #34, this PR is identical to sindresorhus/gh-got#32)

Copy link
Contributor

@hutson hutson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itaisteinherz it looks like sindresorhus/got@9a966ec has not been released yet.

Can you please confirm that?

Also, in addition to this change, the minimum version of got should probably be bumped because removing this code requires that the underlying version of got has the functionality.

@itaisteinherz
Copy link
Contributor Author

@hbetts you are correct. Let's put this on hold until the next version of got is released (and then I'll bump its version as well).

@itaisteinherz
Copy link
Contributor Author

got v9.2.0 has been released 🎉 I've bumped its minimum version. @hbetts can this be merged now?

@itaisteinherz
Copy link
Contributor Author

Ping @hbetts @rarkins

@hutson hutson merged commit 752042c into singapore:master Oct 9, 2018
@hutson
Copy link
Contributor

hutson commented Oct 9, 2018

@itaisteinherz I was able to merge your change, but I won't be able to publish your change for about 8 or so hours (I don't have access to what I need to publish the change).

@hutson
Copy link
Contributor

hutson commented Oct 10, 2018

Version 9.0.1 has been published with this refactor.

@itaisteinherz itaisteinherz deleted the patch-1 branch October 10, 2018 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants