Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type declarations do not account for fs.Stats[] return type #139

Open
starpit opened this issue Jan 3, 2020 · 2 comments
Open

type declarations do not account for fs.Stats[] return type #139

starpit opened this issue Jan 3, 2020 · 2 comments
Labels
bug help wanted

Comments

@starpit
Copy link

starpit commented Jan 3, 2020

fast-glob supports { stats: true }, which yields fs.Stats objects as opposed to strings. it looks like index.d.ts does not account for this?

Type 'string[]' is not assignable to type 'Stats[]'.
Type 'string' is not assignable to type 'Stats'.
@sindresorhus
Copy link
Owner

Probably just an oversight. PR welcome to fix this.

@alex-page alex-page mentioned this issue Apr 3, 2021
Closed
@alex-page
Copy link

@starpit I had a go at fixing this in #173, let me know if you see any issues. I am new to to typescript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sindresorhus @starpit @alex-page