-
-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Xiangqi #3110
base: main
Are you sure you want to change the base?
Add Xiangqi #3110
Conversation
unicorn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the sentence in the top of your repo doesn't fit the guidelines
@TupleType can you elaborate what you mean? |
Includes a succinct description of the project/theme at the top of the readme. (Example) |
@TupleType I think the sentence I have
is a pretty succint description of what xiangqi is. Could you clarify why you think it does not fit the guidelines? If you have a better wording in mind, of course happy to receive feedback :) |
I mean the first line of the readme should be second |
@TupleType Do you mean that I should move the sentence
after the description? I don't mind the change, but why do you think it's against the guidelines? I took as model the example repository linked in the guidelines: https://github.com/woop/awesome-quantified-self and that also starts with
before the description. Similarly other lists: https://github.com/sindresorhus/awesome-electron , so I don't think it's against the guidelines for that to come before the topic description 🤔 As far as I can tell, I don't think it's required to be quoted (with |
Hi @sindresorhus 🖖 , I think this PR is ready, let me know if you think otherwise. |
@sindresorhus friendly ping :) |
__k |
@sindresorhus world's gentlest ping :) Please let me know if this is good to go |
f0658c5
to
993cee4
Compare
@sindresorhus weekly ping ☮️ |
@lucaferranti Please stop pinging. All it does is move it to the bottom of my review list. Getting a list merged generally takes time. |
I understand and apologize for bothering. You are running a great open project here on your free time and this is great! I am sorry I broke the etiquette by pinging you and I did not mean to sound rude or pushy. Now that I know the rules, I am happy with your answer and happy to wait as long as it takes. Thanks for informing me and again, sorry for the inconvenience |
Should be:
Same everywhere. Run the list through ChatGPT to fix typos. |
TIL, the correct spelling is dynasty and not dinasty 😅 Thank you very much for the review! The points raised should be fixed now |
I do believe that adding the Chinese words on the list beside the English titles does not give added value. This is the case on the Opening section. |
https://github.com/lucaferranti/awesome-xiangqi
This list collects popular resources about xiangqi, a two-players combinatorial game from China similar to chess, hence also known as Chinese chess. The game is popular and rich in tacticts, strategic thinking and creativity. However, it is sometimes different to find resources, especially in English. This list aims to provide a centralized list of awesome resources to learn and practice the game, hopefully helping in its promotion and diffusion worldwide.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Add Name of List
. It should not contain the wordAwesome
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Awesome X
and a logo withAwesome X
. You can put the header image in a#
(Markdown header) or<h1>
.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. The casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.