Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xiangqi #3110

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Xiangqi #3110

wants to merge 2 commits into from

Conversation

lucaferranti
Copy link

https://github.com/lucaferranti/awesome-xiangqi

This list collects popular resources about xiangqi, a two-players combinatorial game from China similar to chess, hence also known as Chinese chess. The game is popular and rich in tacticts, strategic thinking and creativity. However, it is sometimes different to find resources, especially in English. This list aims to provide a centralized list of awesome resources to learn and practice the game, hopefully helping in its promotion and diffusion worldwide.

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it. Instead use #2242 for incubation visibility.
  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List. It should not contain the word Awesome.
    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • add Swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description of the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb. It should not contain the name of the list.
    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The title of your entry should be title-cased and the URL to your list should end in #readme.
    • Example: - [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
  • No blockchain-related lists.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • The default branch should be named main, not master.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to a maximum of half the width of the original image.
    • Don't include both a title saying Awesome X and a logo with Awesome X. You can put the header image in a # (Markdown header) or <h1>.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
    • Must not feature Contributing or Footnotes sections.
  • Has an appropriate license.
    • We strongly recommend the CC0 license, but any Creative Commons license will work.
      • Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0 (replace <user> and <repo> accordingly).
    • A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
    • Place a file named license or LICENSE in the repo root with the license text.
    • Do not add the license name, text, or a Licence section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.
    • To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. The casing is up to you.
    • It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
    • The section should not appear in the Table of Contents.
  • All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Does not use hard-wrapping.
  • Does not include a CI (e.g. GitHub Actions) badge.
    You can still use a CI for linting, but the badge has no value in the readme.
  • Does not include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

@lucaferranti
Copy link
Author

unicorn

Copy link

@TupleType TupleType left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the sentence in the top of your repo doesn't fit the guidelines

@lucaferranti
Copy link
Author

@TupleType can you elaborate what you mean?

@TupleType TupleType mentioned this pull request Jul 18, 2024
@TupleType
Copy link

@TupleType can you elaborate what you mean?

Includes a succinct description of the project/theme at the top of the readme. (Example)
✅ Mobile operating system for Apple phones and tablets.
✅ Prototyping interactive UI designs.
❌ Resources and tools for iOS development.
❌ Awesome Framer packages and tools.

@lucaferranti
Copy link
Author

lucaferranti commented Jul 18, 2024

@TupleType I think the sentence I have

Xiangqi, also known as Chinese chess, is a two-players abstract strategy board-game from China, with a long history of tradition, theory and tactics.

is a pretty succint description of what xiangqi is.

Could you clarify why you think it does not fit the guidelines? If you have a better wording in mind, of course happy to receive feedback :)

@TupleType
Copy link

TupleType commented Jul 18, 2024

I mean the first line of the readme should be second

@lucaferranti
Copy link
Author

@TupleType Do you mean that I should move the sentence

A curated list of xiangqi related resources.

after the description? I don't mind the change, but why do you think it's against the guidelines? I took as model the example repository linked in the guidelines: https://github.com/woop/awesome-quantified-self and that also starts with

Carefully curated list of awesome Quantified Self resources.

before the description. Similarly other lists: https://github.com/sindresorhus/awesome-electron , so I don't think it's against the guidelines for that to come before the topic description 🤔 As far as I can tell, I don't think it's required to be quoted (with > ) either.

@lucaferranti
Copy link
Author

Hi @sindresorhus 🖖 ,

I think this PR is ready, let me know if you think otherwise.

@lucaferranti
Copy link
Author

@sindresorhus friendly ping :)

@jackaubone
Copy link

__k

readme.md Show resolved Hide resolved
@lucaferranti
Copy link
Author

@sindresorhus world's gentlest ping :)

Please let me know if this is good to go

@sindresorhus sindresorhus force-pushed the main branch 5 times, most recently from f0658c5 to 993cee4 Compare August 8, 2024 13:04
@lucaferranti
Copy link
Author

@sindresorhus weekly ping ☮️

@sindresorhus
Copy link
Owner

@lucaferranti Please stop pinging. All it does is move it to the bottom of my review list. Getting a list merged generally takes time.

@lucaferranti
Copy link
Author

lucaferranti commented Aug 8, 2024

I understand and apologize for bothering.

You are running a great open project here on your free time and this is great! I am sorry I broke the etiquette by pinging you and I did not mean to sound rude or pushy. Now that I know the rules, I am happy with your answer and happy to wait as long as it takes. Thanks for informing me and again, sorry for the inconvenience

@sindresorhus
Copy link
Owner

sindresorhus commented Oct 22, 2024

Xiangqi in Xiangqi, also known as Chinese chess, is a two-players abstract strategy board-game from China, with a long history of tradition, theory and tactics. should be linkified to https://en.wikipedia.org/wiki/Xiangqi


https://www.chessdb.cn/query/ - Interactive board to search positions and statistics about their outcomes and continuations.

Should be:

[ChessDB](https://www.chessdb.cn/query/) - Interactive board to search positions and statistics about their outcomes and continuations.

Same everywhere.


Run the list through ChatGPT to fix typos.

@lucaferranti
Copy link
Author

lucaferranti commented Oct 22, 2024

TIL, the correct spelling is dynasty and not dinasty 😅

Thank you very much for the review! The points raised should be fixed now

@theodorosploumis
Copy link

I do believe that adding the Chinese words on the list beside the English titles does not give added value. This is the case on the Opening section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants