Skip to content
This repository has been archived by the owner on May 16, 2021. It is now read-only.

Sinatra master breaks namespace spec #200

Closed
zzak opened this issue May 4, 2016 · 4 comments
Closed

Sinatra master breaks namespace spec #200

zzak opened this issue May 4, 2016 · 4 comments
Labels
blocking release
Milestone
2.0.0

Comments

@zzak
Copy link
Member

zzak commented May 4, 2016

  1. $ sinatra=master bundle
  2. $ sinatra=master bundle exec rake spec

Produces the following errors:

Failures:

  1) Sinatra::Namespace HTTP GET error handling falls back to the handler defined in the base app
     Failure/Error: last_response.body.should        eq 'nicht gefunden' unless verb == :head

       expected: "nicht gefunden"
            got: "not found..."

       (compared using ==)
     # ./spec/namespace_spec.rb:515:in `block (5 levels) in <top (required)>'

  2) Sinatra::Namespace HTTP POST error handling falls back to the handler defined in the base app
     Failure/Error: last_response.body.should        eq 'nicht gefunden' unless verb == :head

       expected: "nicht gefunden"
            got: "not found..."

       (compared using ==)
     # ./spec/namespace_spec.rb:515:in `block (5 levels) in <top (required)>'

  3) Sinatra::Namespace HTTP PUT error handling falls back to the handler defined in the base app
     Failure/Error: last_response.body.should        eq 'nicht gefunden' unless verb == :head

       expected: "nicht gefunden"
            got: "not found..."

       (compared using ==)
     # ./spec/namespace_spec.rb:515:in `block (5 levels) in <top (required)>'

  4) Sinatra::Namespace HTTP DELETE error handling falls back to the handler defined in the base app
     Failure/Error: last_response.body.should        eq 'nicht gefunden' unless verb == :head

       expected: "nicht gefunden"
            got: "not found..."

       (compared using ==)
     # ./spec/namespace_spec.rb:515:in `block (5 levels) in <top (required)>'

  5) Sinatra::Namespace HTTP OPTIONS error handling falls back to the handler defined in the base app
     Failure/Error: last_response.body.should        eq 'nicht gefunden' unless verb == :head

       expected: "nicht gefunden"
            got: "not found..."

       (compared using ==)
     # ./spec/namespace_spec.rb:515:in `block (5 levels) in <top (required)>'

  6) Sinatra::Namespace HTTP PATCH error handling falls back to the handler defined in the base app
     Failure/Error: last_response.body.should        eq 'nicht gefunden' unless verb == :head

       expected: "nicht gefunden"
            got: "not found..."

       (compared using ==)
     # ./spec/namespace_spec.rb:515:in `block (5 levels) in <top (required)>'

Finished in 4.23 seconds
856 examples, 6 failures

travis log
@zzak
Copy link
Member Author

zzak commented May 5, 2016 •
edited
Loading

Essentially all of the namespace tests fail now: https://travis-ci.org/sinatra/sinatra-contrib/jobs/127980688

Even more so because of sinatra/sinatra#1086

@zzak zzak mentioned this issue May 6, 2016
Merged
@stjhimy
Copy link
Contributor

stjhimy commented Jun 21, 2016

I will work on this next week, it seems still failing with Sinatra master.

@zzak
Copy link
Member Author

zzak commented Jun 23, 2016

@stjhimy Any help is appreciated here! This is the major blocker atm

@zzak zzak added this to the 2.0.0 milestone Jun 23, 2016
@zzak zzak mentioned this issue Jul 11, 2016
Closed
zzak pushed a commit that referenced this issue Jul 15, 2016
Skip failing Namespace related specs /cc #200
aaa391d
@304 304 mentioned this issue Jul 15, 2016
Merged
@zzak
Copy link
Member Author

zzak commented Jul 16, 2016

Fixed by #207

@zzak zzak closed this as completed Jul 16, 2016
zzak pushed a commit that referenced this issue Jul 19, 2016
Use Mustermann from master until a release is made
9500d76 
Since master has a patch which fixes the missing `:+` implementation for
Regular and Sinatra-based patterns.

We can also re-enable the namespace specs for accepting regular expressions for
path concatination.

/cc #200 and #207
zzak pushed a commit that referenced this issue Jul 19, 2016
There is still a problem with prefixing methods with conditions
2d2a445 
The following specs are still failing:
https://github.com/sinatra/sinatra-contrib/blob/9500d76/spec/namespace_spec.rb#L170-L209

/cc #200 and #207
zzak pushed a commit to zzak/sinatra-contrib that referenced this issue Jul 22, 2016
Skip failing Namespace related specs /cc sinatra#200
eedc923
zzak pushed a commit to zzak/sinatra-contrib that referenced this issue Jul 22, 2016
Use Mustermann from master until a release is made
b1fd9f1 
Since master has a patch which fixes the missing `:+` implementation for
Regular and Sinatra-based patterns.

We can also re-enable the namespace specs for accepting regular expressions for
path concatination.

/cc sinatra#200 and sinatra#207
zzak pushed a commit to zzak/sinatra-contrib that referenced this issue Jul 22, 2016
There is still a problem with prefixing methods with conditions
9474e91 
The following specs are still failing:
https://github.com/sinatra/sinatra-contrib/blob/9500d76/spec/namespace_spec.rb#L170-L209

/cc sinatra#200 and sinatra#207
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocking release
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@stjhimy @zzak