Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for Multithreaded modes #993

Merged
merged 2 commits into from
Apr 10, 2015
Merged

Add documentation for Multithreaded modes #993

merged 2 commits into from
Apr 10, 2015

Conversation

kgrz
Copy link
Member

@kgrz kgrz commented Apr 6, 2015

Issue: #941
Discussion: #937

Although threading depends on the underlying Rack handler, the absence
of any mention of multi-threaded mode/concurrency seems to confuse users
and it was decided to add some pointers to clarify this.

@kgrz
Add documentation for Multithreaded modes
348954c 
Issue: sinatra#941
Discussion: sinatra#937

Although threading depends on the underlying Rack handler, the absence
of any mention of multi-threaded mode/concurrency seems to confuse users
and it was decided to add some pointers to clarify this.
@kgrz
Copy link
Member Author

kgrz commented Apr 6, 2015

I probably should add a checklist for other languages. OR should I just use Google Translate?

@davydovanton
Copy link
Contributor

@kgrz I can translate this to russian 😃
P.S.: I think checklist is more suitable here

@kytrinyx
Copy link
Contributor

kytrinyx commented Apr 8, 2015

Yeah, a checklist would be great. I can translate it to French.

@kgrz kgrz mentioned this pull request Apr 9, 2015
Closed
@kgrz
Copy link
Member Author

kgrz commented Apr 9, 2015

Done, added the checklist on the issue

@davydovanton davydovanton mentioned this pull request Apr 9, 2015
Merged
@DyegoCosta
Copy link
Contributor

@kgrz The Multi-threading section is missing a link on the Table of Content.
And is it intentionally inside the Command Line section?

And I'll translate it to pt-br :D

@DyegoCosta DyegoCosta mentioned this pull request Apr 9, 2015
Merged
@kgrz
Copy link
Member Author

kgrz commented Apr 9, 2015

@DyegoCosta Good catch! I've added the link under ToC.

Yes, the location under Command Line section was intentional since that was the part that talked about how to start the app. I can move it to a better place if you think there's one.

@DyegoCosta
Copy link
Contributor

@kgrz I was just wondering. Since right now it is all about how to start the app I believe it's ok to be in the Command Line section. Apparently it won't get any bigger but if it does maybe it could have it own section 😅

@kgrz kgrz force-pushed the add-documentation-for-threaded-modes branch from 6730fda to 009a4a5 Compare April 9, 2015 13:08
kytrinyx added a commit that referenced this pull request Apr 10, 2015
@kytrinyx
Merge pull request #993 from kgrz/add-documentation-for-threaded-modes
6ac6acc 
Add documentation for Multithreaded modes
@kytrinyx kytrinyx merged commit 6ac6acc into sinatra:master Apr 10, 2015
@kytrinyx
Copy link
Contributor

Thanks!

@ghost ghost mentioned this pull request Jun 24, 2015
Merged
@porras porras mentioned this pull request Jul 15, 2015
Merged
kytrinyx added a commit that referenced this pull request Sep 11, 2015
@kytrinyx
Merge pull request #993 from kgrz/add-documentation-for-threaded-modes
c812e1c 
Add documentation for Multithreaded modes
@patrickgramatowski patrickgramatowski mentioned this pull request Jun 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kgrz @davydovanton @kytrinyx @DyegoCosta