fix(hostAuth): allow underscores in subdomains #2069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As best I can tell underscores are perfectly valid in subdomains. When deploying the host authorization, some of our customers that used underscores in their subdomains were not able to login. Here's some supporting evidence: https://stackoverflow.com/a/2183140/2187010
|
Actually, the more I read about this, the more I think this is probably the wrong approach, so closing. |
|
Yeah this is a bit tricky, I looked at Rails for inspiration here but later I saw this comment #2053 (comment) I also remember seeing underscores being discussed in the context of Rails, I don't remember what the conclusion was. Maybe I can find the issue again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As best I can tell underscores are perfectly valid in subdomains. When deploying the host authorization in Sinatra 4.1, some of our customers that used underscores in their subdomains were not able to login.
Here's some supporting evidence: https://stackoverflow.com/a/2183140/2187010
but then again there is newer stuff that seems to suggest underscores are in the process of being sunset: https://www.ssl.com/faqs/underscores-not-allowed-in-domain-names/
Totally ok if you think this is not a welcome change.